Bojan Smojver wrote:
On Tue, 2009-03-03 at 17:57 -0600, William A. Rowe, Jr. wrote:
Setting the flag is sufficient.
The fact that a handle shouldn't be closed on exec in an apr-sense makes
no difference to whether it should be closed on non-apr exec() calls.
Just before I make the change, let me understand this correctly. What
you're saying is that we should not then call apr_file_inherit_set()
here, because it will change that logic even on non-apr exec(), but
rather simply do inside apr_file_open_stdin/stdout/stderr():
thefile->flags |= APR_INHERIT;
Correct?
I believe that is correct. Anyone else care to validate? As far as I know
this change is a noop, until the introduction of this most recent file
inheritance patch for CLOEXEC.
