On Sat, Sep 19, 2009 at 10:09 AM, Graham Leggett <minf...@sharp.fm> wrote:
> Hmmm. I think it's reasonable to return NULL in the failure cases, where
> NULL means "out of memory".

Fair enough. The one place this doesn't work is when expanding the
bucket array in apr_hash_set() (since it returns NULL), but in that
case we can just skip the expansion if the apr_pool_create() fails,
and retry it next time.

Attached is a revised patch -- thanks for the feedback.

Neil

Attachment: apr_hash_mem_leak-2.patch
Description: Binary data

Reply via email to