On 06.09.2013 01:48, William A. Rowe Jr. wrote: > On Thu, 05 Sep 2013 23:56:48 +0200 > Rainer Jung <[email protected]> wrote: > >> On 05.09.2013 21:19, William A. Rowe Jr. wrote: >>> On Thu, 5 Sep 2013 14:53:43 +0200 >>> "Bert Huijben" <[email protected]> wrote: >>> >>>> >>>>> -----Original Message----- >>>>> From: [email protected] [mailto:[email protected]] >>>>> Sent: donderdag 29 augustus 2013 20:49 >>>>> To: [email protected] >>>>> Subject: svn commit: r1518760 - in /apr/apr/branches/1.4.x: >>>>> CMakeLists.txt README.cmake include/apr.hwc >>>>> >>>>> Author: trawick >>>>> Date: Thu Aug 29 18:48:38 2013 >>>>> New Revision: 1518760 >>>>> >>>>> URL: http://svn.apache.org/r1518760 >>>>> Log: >>>>> Add cmake build for APR 1.4.x. >>>>> >>>>> apr.hwc is the same as apr.hw other than making the APR_HAVE_IPV6 >>>>> setting a variable. >>>>> >>>>> This is not currently in the 1.5.x branch, which sees little >>>>> use. >>>>> >>>>> Added: >>>>> apr/apr/branches/1.4.x/CMakeLists.txt (with props) >>>>> apr/apr/branches/1.4.x/README.cmake (with props) >>>>> apr/apr/branches/1.4.x/include/apr.hwc (with props) >>>>> >>>>> Added: apr/apr/branches/1.4.x/CMakeLists.txt >>>>> URL: >>>>> http://svn.apache.org/viewvc/apr/apr/branches/1.4.x/CMakeLists.txt?rev=1 >>>>> 518760&view=auto >>>>> ========================================================== >>>>> ==================== >>>>> --- apr/apr/branches/1.4.x/CMakeLists.txt (added) >>>>> +++ apr/apr/branches/1.4.x/CMakeLists.txt Thu Aug 29 18:48:38 2013 >>>>> @@ -0,0 +1,317 @@ >>>>> +PROJECT(APR C) >>>>> + >>>>> +# Licensed to the Apache Software Foundation (ASF) under one or >>>>> more +# contributor license agreements. See the NOTICE file >>>>> distributed with +# this work for additional information regarding >>>>> copyright ownership. +# The ASF licenses this file to You under >>>>> the Apache License, Version 2.0 +# (the "License"); you may not >>>>> use this file except in compliance with +# the License. You may >>>>> obtain a copy of the License at +# >>>>> +# http://www.apache.org/licenses/LICENSE-2.0 >>>>> +# >>>>> +# Unless required by applicable law or agreed to in writing, >>>>> software +# distributed under the License is distributed on an "AS >>>>> IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either >>>>> express or implied. >>>>> +# See the License for the specific language governing permissions >>>>> and +# limitations under the License. >>>>> +# >>>>> +# Read README.cmake before using this. >>>>> + >>>>> +CMAKE_MINIMUM_REQUIRED(VERSION 2.8) >>>>> + >>>>> +OPTION(APR_INSTALL_PRIVATE_H "Install selected private .h files >>>>> (for httpd)" OFF) >>>>> +OPTION(APR_HAVE_IPV6 "IPv6 support" ON) >>>>> +OPTION(APR_SHOW_SETTINGS "Show the build configuration" ON) >>>>> +OPTION(APR_BUILD_TESTAPR "Build the test suite" OFF) >>>> <snip> >>>> >>>> You also need these APR_INSTALL_PRIVATE_H private .h files to build >>>> Subversion. >>>> >>>> With Subversion <= 1.8 we assumed that you always have the APR >>>> sources available, but on Subversion trunk just having these >>>> headers available with your APR allows you to build against a >>>> pre-compiled APR. >>>> >>>> So it might be useful to note this somewhere. >>> This is true for mod_jk as well. So much for the definition of >>> 'private', and protracted early 00's debates that caused that >>> specific functionality to be private, sigh :) >> I might be wrong, but I didn't find any traces of such use of the >> private headers in the mod_jk source files. > I must have been thinking about the deprecated ntservice and even > perhaps the tcnative connector, sorry for the confusion. In any > case, it seems reasonable based on adoption to include in a win32 > install the arch/win32 private headers.
Actually, the use of that one private header in Subversion on Windows is more or less a result of (my) laziness. It wouln't have hurt, back in the day, if I'd just made it public. These days, of course, Windows has a standard API for converting between UTF-16-LE and UTF-8. Perhaps it's finally time for Subversion to start using it, and not assume it has to be compatible with WinNT 3.5. -- Brane
