On Thu, Mar 23, 2017 at 1:01 PM, Nick Kew <n...@apache.org> wrote:
> On Thu, 2017-03-23 at 10:13 -0700, Gregg Smith wrote:
>
>> My retro build changes and Jan's revised patch have been commited.
>> Windows should be good to go.
>
> Brilliant, thanks both.
+1
> I'll take the activity on this issue as an indication that
> Windows was already *otherwise* good. Unless we hear to
> the contrary!
I'll have more before month end, but no availability in the next few days
to review Windows. I haven't built 1.x branch against openssl 110 yet,
so here's some Unix (latest Fedora) feedback;
../../apr-1.6/file_io/unix/dir.c: In function ‘apr_dir_read’:
../../apr-1.6/file_io/unix/dir.c:162:5: warning: ‘readdir_r’ is
deprecated [-Wdeprecated-declarations]
ret = readdir_r(thedir->dirstruct, thedir->entry, &retent);
^~~
In file included from
/home/wrowe/dev/apr-1.6/include/arch/unix/apr_arch_file_io.h:50:0,
from ../../apr-1.6/file_io/unix/dir.c:17:
/usr/include/dirent.h:183:12: note: declared here
extern int readdir_r (DIR *__restrict __dirp,
^~~~~~~~~
../../apr-util-1.6/dbm/apr_dbm_ndbm.c: In function ‘vt_ndbm_open’:
../../apr-util-1.6/dbm/apr_dbm_ndbm.c:100:25: warning: passing
argument 1 of ‘dbm_open’ discards ‘const’ qualifier from pointer
target type [-Wdiscarded-qualifiers]
file = dbm_open(pathname, dbmode, apr_posix_perms2mode(perm));
^~~~~~~~
In file included from ../../apr-util-1.6/dbm/apr_dbm_ndbm.c:29:0:
/usr/include/ndbm.h:55:14: note: expected ‘char *’ but argument is of
type ‘const char *’
extern DBM *dbm_open (char *file, int flags, int mode);
^~~~~~~~
And normal gummed up private vs public autogunk side-effects;
In file included from /usr/include/mysql/my_config.h:14:0,
from /usr/include/mysql/my_global.h:75,
from ../../apr-util-1.6/dbd/apr_dbd_mysql.c:38:
/usr/include/mysql/my_config-x86_64.h:649:0: warning: "PACKAGE_NAME" redefined
#define PACKAGE_NAME "MySQL Server"
In file included from ../../apr-util-1.6/dbd/apr_dbd_mysql.c:22:0:
/home/wrowe/dev/build/aprutil16-ossl110/include/private/apu_config.h:175:0:
note: this is the location of the previous definition
#define PACKAGE_NAME ""
In file included from /usr/include/mysql/my_config.h:14:0,
from /usr/include/mysql/my_global.h:75,
from ../../apr-util-1.6/dbd/apr_dbd_mysql.c:38:
/usr/include/mysql/my_config-x86_64.h:650:0: warning: "PACKAGE_STRING" redefined
#define PACKAGE_STRING "MySQL Server 10.1.21"
In file included from ../../apr-util-1.6/dbd/apr_dbd_mysql.c:22:0:
/home/wrowe/dev/build/aprutil16-ossl110/include/private/apu_config.h:178:0:
note: this is the location of the previous definition
#define PACKAGE_STRING ""
In file included from /usr/include/mysql/my_config.h:14:0,
from /usr/include/mysql/my_global.h:75,
from ../../apr-util-1.6/dbd/apr_dbd_mysql.c:38:
/usr/include/mysql/my_config-x86_64.h:651:0: warning:
"PACKAGE_TARNAME" redefined
#define PACKAGE_TARNAME "mysql"
In file included from ../../apr-util-1.6/dbd/apr_dbd_mysql.c:22:0:
/home/wrowe/dev/build/aprutil16-ossl110/include/private/apu_config.h:181:0:
note: this is the location of the previous definition
#define PACKAGE_TARNAME ""
In file included from /usr/include/mysql/my_config.h:14:0,
from /usr/include/mysql/my_global.h:75,
from ../../apr-util-1.6/dbd/apr_dbd_mysql.c:38:
/usr/include/mysql/my_config-x86_64.h:652:0: warning:
"PACKAGE_VERSION" redefined
#define PACKAGE_VERSION "10.1.21"
In file included from ../../apr-util-1.6/dbd/apr_dbd_mysql.c:22:0:
/home/wrowe/dev/build/aprutil16-ossl110/include/private/apu_config.h:187:0:
note: this is the location of the previous definition
#define PACKAGE_VERSION ""
