On 01.04.2017 03:22, Nick Kew wrote: > fdatasync on Mac is a mess. What I’ve been hacking at is described in > https://bugs.freedesktop.org/show_bug.cgi?id=74873 > where they face the same issue. > > My inclination is to steer clear of this mess. We can disable fdatasync on > mac > with a simple patch: > > $ svn diff > Index: configure.in > =================================================================== > --- configure.in (revision 1789687) > +++ configure.in (working copy) > @@ -573,6 +573,11 @@ > OSDIR="unix" > eolstr="\\n" > ;; > + *darwin* ) > + ac_cv_func_fdatasync="no" # Mac OS X wrongly reports it has > fdatasync() > + OSDIR="unix" > + eolstr="\\n" > + ;; > *) > OSDIR="unix" > eolstr="\\n” > > Comments? Objections?
r1790200, with a slight tweak that the pattern is *apple-darwin*, as used elsewhere in configure.in. I also implemented the use of fcntl(.., F_FULLFSYNC) instead of fsync, when it's available. This should probably go into 1.6.x, too, I guess. -- Brane
