> -----Original Message-----
> From: William A Rowe Jr [mailto:wr...@rowe-clan.net]
> Sent: woensdag 4 oktober 2017 18:14
> To: Bert Huijben <b...@qqmail.nl>
> Cc: APR Developer List <dev@apr.apache.org>
> Subject: Re: [PATCH] Building apr-util with recent libexpat2 using CMake
>
> On Wed, Oct 4, 2017 at 10:23 AM, Bert Huijben <b...@qqmail.nl> wrote:
> > Hi,
> >
> > Building apr-util with a recent libexpat2 (2.2.4) requires referencing
> > an additional .c file on Windows. The attached patch fixes the CMake build.
> > Perhaps somebody more experienced with CMake can create a patch that
> > would be compatible with older and newer versions.
> >
> > Note that including this file on other platforms is safe. It will just
> > be an almost empty file on those platforms.
>
> Actually, this goes the other way. CMakeLists.txt should only reference the
> desired libexpat[MT].lib, not source files in expat. It's up to the expat
> maintainers to describe the Windows build, which they've been doing well
> since the late 1.9x flavors.
>
> See the "expat removed" thread. Please check out 1.6.x branch of apr-util for
> the currently proposed solution I intend to tag, once I've resolved all of
> Steffen's issues (some offlist, since his connectivity was limited over the
> weekend.)
Currently the cmake file on trunk directly references these files from the main
apr project, so this code is currently broken in the same way.
Currently both Apache Subversion and Apache Serf rely on finding the xml
library produced by the apr-util (or apr 2.0) build in their build scripts for
Windows on all maintenance branches... without code in these scripts to
override this.
Bert
