Since these are in libbsd and libglibc, and we already include these both (right?) then we won't change the dependency graph.
If you were relying on adding an extra dependency, I'd suggest we skip it for 1.6-current and only backport to 1.7.0-future. The package maintainers would appreciate not switching dependency graphs on subversion releases. On Tue, Apr 3, 2018 at 3:07 PM, Yann Ylavic <ylavic....@gmail.com> wrote: > I was thinking of backporting both arc4random() and Linux' getrandom() > changes actually, objections? > They are the best entropy/random source available for these platform, > and as Bill said, no API constraints... > > On Tue, Apr 3, 2018 at 9:22 PM, Eric Covener <cove...@gmail.com> wrote: >> I think that's right, the thing it's correcting is trunk-only (I >> checked 1.7 had no grep -ri arc4random_buf) >> >> On Tue, Apr 3, 2018 at 3:19 PM, William A Rowe Jr <wr...@rowe-clan.net> >> wrote: >>> Eric, >>> >>> Confirming; this is a trunk-only change? I don't see 1.7/1.6 commits. >>> >>> On Wed, Jan 10, 2018 at 8:53 AM, <cove...@apache.org> wrote: >>>> Author: covener >>>> Date: Wed Jan 10 14:53:43 2018 >>>> New Revision: 1820755 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=1820755&view=rev >>>> Log: >>>> fix ifdef for arc4random >>>> >>>> r1814239 added: >>>> AC_CHECK_FUNCS(arc4random_buf) >>>> >>>> Which only defines HAVE_ARC4RANDOM_BUF >>>> >>>> >>>> >>>> >>>> Modified: >>>> apr/apr/trunk/misc/unix/rand.c >>>> >>>> Modified: apr/apr/trunk/misc/unix/rand.c >>>> URL: >>>> http://svn.apache.org/viewvc/apr/apr/trunk/misc/unix/rand.c?rev=1820755&r1=1820754&r2=1820755&view=diff >>>> ============================================================================== >>>> --- apr/apr/trunk/misc/unix/rand.c (original) >>>> +++ apr/apr/trunk/misc/unix/rand.c Wed Jan 10 14:53:43 2018 >>>> @@ -224,7 +224,7 @@ APR_DECLARE(apr_status_t) apr_generate_r >>>> length -= rc; >>>> } while (length > 0); >>>> >>>> -#elif defined(HAVE_ARC4RANDOM) >>>> +#elif defined(HAVE_ARC4RANDOM_BUF) >>>> >>>> arc4random_buf(buf, length); >>>> >>>> >>>> >> >> >> >> -- >> Eric Covener >> cove...@gmail.com
