Re: svn commit: r1835348 - in /apr/apr/trunk: CHANGES build.conf include/apr_json.h json/ json/apr_json.c json/apr_json_decode.c json/apr_json_encode.c test/Makefile.in test/abts_tests.h test/testjson.c test/testutil.h

[Graham Leggett]

On 08 Jul 2018, at 2:55 PM, Yann Ylavic <ylavic....@gmail.com> wrote:

>> +            if (*p == 'u') {
>> +                if (p + 4 >= e) {
>> +                    status = APR_EOF;
>> +                    goto out;
>> +                }
>> +                p += 5;
>> +                string.len += 4;/* an UTF-8 character spans at most 4 bytes 
>> */
>> +                break;
> 
> Why break here and ignore potential/subsequent '\u....' encodings in
> the same json string?

This was broken, I’ve fixed it and added a test in r1835360.

Regards,
Graham
—