Re: svn commit: r1839047 - in /apr/apr/branches/1.7.x: ./ misc/win32/start.c

[Christophe JAILLET]

Le 25/08/2018 à 20:18, Yann Ylavic a écrit :

On Sat, Aug 25, 2018 at 3:28 PM <rj...@apache.org> wrote:

--- apr/apr/branches/1.7.x/misc/win32/start.c (original)
+++ apr/apr/branches/1.7.x/misc/win32/start.c Sat Aug 25 13:28:30 2018
@@ -39,7 +39,7 @@ int APR_DECLARE_DATA apr_app_init_comple
   * _CRT_BLOCK to trick the system into trusting our store.
   */
  static int warrsztoastr(const char * const * *retarr,
-                        const wchar_t * arrsz, int args)
+                        const wchar_t * arrsz)
  {
      const apr_wchar_t *wch;
      apr_size_t totlen;
@@ -50,11 +50,9 @@ static int warrsztoastr(const char * con
      char *strs;
      int arg;

-    if (args < 0) {
-        for (args = 1, wch = arrsz; wch[0] || wch[1]; ++wch)
-            if (!*wch)
-                ++args;
-    }
+    for (args = 1, wch = arrsz; wch[0] || wch[1]; ++wch)
+        if (!*wch)
+            ++args;
      wsize = 1 + wch - arrsz;

Hmm, does this compile (including in trunk)? I don't see where args is
declared now...

Regards,
Yann.

Hmmm, looks embarrassing.
Sorry for this obviously un-compiled and bogus commit.

I guess that we should have:
   int arg, args;

CJ