On Wed, Jun 22, 2022 at 10:30 AM Yann Ylavic <ylavic....@gmail.com> wrote:
>
> On Wed, Jun 22, 2022 at 2:26 PM Ivan Zhakov via dev <dev@apr.apache.org>
> wrote:
> >
> > As far I understand Apache Infra recommends to migrate Continuous
> > Integration builds from Travis to GitHub Actions.
> >
> > I've added initial configuration for GitHub Actions for APR project:
> > https://svn.apache.org/repos/asf/apr/apr/trunk/.github/workflows/
> >
> > GitHub supports Linux, macOS and Windows runners.
>
> Nice work Ivan, thanks a bunch!
>
> Regards;
> Yann.
>
> PS: now the macos guys have some work
> (https://github.com/apache/apr/runs/7004338300?check_suite_focus=true)
I think on mac we do not have xml2-config and build/xml.m4 does not
actually set xml2_LIBS to anything when xml2 is auto-detected.
I think a similar path is wrong when --with-xml2 passes a dir instead
of a path to xml2-config.
I am testing this which seemed to just work for the no xml2 args at
all case w/ no xml2-config:
Index: build/xml.m4
===================================================================
--- build/xml.m4 (revision 1902172)
+++ build/xml.m4 (working copy)
@@ -177,6 +177,7 @@
else
xml2_CPPFLAGS="-I$withval/include/libxml2"
xml2_LDFLAGS="-L$withval/lib64 -L$withval/lib"
+ xml2_LIBS="-lxml2"
fi
APR_ADDTO(CPPFLAGS, [$xml2_CPPFLAGS])
@@ -186,6 +187,7 @@
AC_CHECK_HEADERS(libxml/parser.h, AC_CHECK_LIB(xml2,
xmlCreatePushParserCtxt, [apu_has_libxml2=1]))
fi
], [
+ xml2_LIBS="-lxml2"
AC_CHECK_HEADERS(libxml/parser.h, AC_CHECK_LIB(xml2,
xmlCreatePushParserCtxt, [apu_has_libxml2=1]))
])
AC_SUBST(apu_has_libxml2)
Maybe an autoconf guru can take a look?
--
Eric Covener
cove...@gmail.com
