On Sat, 13 Jul 2024 at 17:40, Ivan Zhakov <i...@apache.org> wrote: > On Mon, 8 Jul 2024 at 21:03, Daniel Sahlberg <daniel.l.sahlb...@gmail.com> > wrote: > >> Hi, >> >> In a thread a while back, I asked about building on win32 and suggested >> to improve the documentation[1]. >> >> At first I wanted to take a look at the website and try to figure out how >> it all connects. >> >> This is the first in what I hope will be a series of patches to improve >> the website. >> >> I have a few things in mind: >> - Building the website on Windows. >> - Fix ASF website check nag about missing link to the privacy policy [2] >> - Making the website more mobile friendly (basically a responsive CSS >> that will fold the menu into a hamburger when browsing on limited width, >> adding website manifest etc, compare with https://subversion.apache.org >> where I did the same thing in r1891758 [3]). >> - Getting APR to build under Visual Studio 2022 and documenting my >> progress in compiling_win32.html >> >> If someone feels strongly about anything of the above ("don't waste your >> time!"), please chime in. >> >> With the introduction done, I'm attaching two patches to create a >> "build.bat" file (replicating the job done by build.sh). I initially copied >> build.sh to create the first patch: >> [[[ >> C:\devel\apr_site>svn copy build.sh build.bat >> ...edit... >> c:\devel\apr_site>svn diff >build_bat_coppiedfromsh.txt >> ]]] >> >> However the copy-from didn't turn up in the patch (and I should probably >> have known that) and since I wasn't sure if this was even wanted, I've also >> created a plain patch with the file added from scratch. >> >> >> Hi Daniel, > > It would be nice to have an option to build a website on Windows. Your > patch looks good, but for some reason it doesn't update the website in my > environment. It seems to be running successfully, but doesn't change files > in docs/ directory: > [[[ > Buildfile: build.xml > Overriding previous definition of reference to classpath > > BUILD SUCCESSFUL > Total time: 0 seconds > ]]] > > I am using JDK 22.0.1. > > Do you have any ideas? > > The problem was that build.bat in the patch contained "%*" (with quotes). In case of no parameters it was evaluated as "", so ant was executed with no targets. I removed quotes and worked for me.
I have committed a tweaked patch in r1919188. I also configured support for the "Build" command for Visual Studio in Open Folder mode. So now the website can be regenerated via the context menu for folder root in Visual Studio. Thanks! -- Ivan Zhakov
