Hi all!

There are cmake configuration files in APR's upstream that were
primarily made to address complexity of building the project on Windows
platform and yet it's the only one supported.

I think it would be really cool to extend it to support all
platforms/configurations. There are however a few things that make it
complicated to implement;

1. Some platform specific code is put into dedicated subdirectories (like
file_io/unix/copy.c). But it's not exactly true because if you look
carefully you realise that the same copy.c is also used in Windows build.
This is not related that much to the build system, but a general idea for
the project, to put shared code away from */unix/. I suggest moving those
files under those subdirs into the parents of unix/ (file_io/unix/copy.c ->
file_io/copy.c), keeping only platform specific code there. Also for
example the os2 version of copy.c simply includes the one for unix. So I
believe this is something that would be an improvement to keeping things
organised.

I think it will be clearer when some ancient platforms are removed from
upstream...

I want to mention that, code from apr-util has this exact structure because
there is a little difference between platforms.

2. apr.h is a complete mess right now; There are four templates that
generate it and I believe some of them are outdated/unused. I want to try
to make the Unix and Windows versions to be as similar to each other
as possible. Perhaps we might rely on macros where different code is
needed. A lot of stuff is still similar, especially in the modern days. The
cmakefication will achieve that!

3. Some parts of cmake that we currently have are tied to Windows too much.
I think there is some refactoring to be done to get it to work on Unix.

4. There are also some Unix specific features that are not fully
implemented in cmake currently.

I will be happy to try and extend cmake to work on Unix, if this feature is
wanted of course.

-- 
Timofei Zhakov

Reply via email to