On 18. 5. 26 22:27, Ivan Zhakov wrote:
On Mon, 18 May 2026 at 21:24, Timofei Zhakov <[email protected]> wrote:
On Mon, May 18, 2026 at 5:22 PM Branko Čibej <[email protected]> wrote:
On 18. 5. 26 17:04, Ivan Zhakov wrote:
[..]
Yes, especially because the Unix and Win32 versions share a lot of
things in common but sometimes need to do it in a slightly
different way.
Also what do you guys think about the fact that Win32 apr.h
includes windows.h? It seems odd to me. APR promises to eliminate
platform dependence by wrapping everything into POSIX-ish style API
Cross-platform API. I'm not sure what you mean by POSIX-ish, but APR
isn't that.
without extra unneeded junk and then all high level code
essentially has GetLastError in the scope. I think if one wants to
explicitly use win32 API, they should include those headers
themselves.
It's a good question. I agree that apr.h should not depend on system
headers like Windows.h. But one reason that Windows error codes are
used in apr_errno.h.
apr.h is a generated, /system-specific/ header. Of course it can and
should depend on system headers if it needs them. It also includes
sys/types.h and sys/socket.h and sys/wait.h and os2.h and so on,
depending on the target. That makes perfect sense.
Sure, if anyone wants to use the Win32 API or a pure POSIX API or the
Linux API or the macOS API along with APR, they have to include those
headers /before/ apr.h.
-- Brane
