Hi Andrea,

- I can't make the "snooze critic" feature work.

This is about issue 3141, I presume.
I'll attach a patch below that shows how the ActionSnooze could be made to work.

The manual may shed some light on the original intention of the not-yet-functional UI.
Some functionality related to critics is simply never implemented yet.

Regards,
Michiel

Index: ToDoItemAction.java
===================================================================
RCS file: /cvs/argouml/src_new/org/argouml/ui/cmd/ToDoItemAction.java,v
retrieving revision 1.5
diff -u -r1.5 ToDoItemAction.java
--- ToDoItemAction.java 11 Jun 2006 14:56:01 -0000 1.5
+++ ToDoItemAction.java 11 Jul 2006 19:32:14 -0000
@@ -33,7 +33,7 @@



-abstract class ToDoItemAction extends UndoableAction {
+abstract public class ToDoItemAction extends UndoableAction {

    private Object rememberedTarget = null;


Index: TabToDo.java
===================================================================
RCS file: /cvs/argouml/src_new/org/argouml/cognitive/ui/TabToDo.java,v
retrieving revision 1.34
diff -u -r1.34 TabToDo.java
--- TabToDo.java 11 Jun 2006 19:01:26 -0000 1.34
+++ TabToDo.java 11 Jul 2006 19:32:29 -0000
@@ -37,6 +37,7 @@
import org.argouml.ui.cmd.ActionNewToDoItem;
import org.argouml.ui.cmd.ActionResolve;
import org.argouml.ui.cmd.ActionSnooze;
+import org.argouml.ui.cmd.ToDoItemAction;
import org.argouml.ui.targetmanager.TargetEvent;
import org.argouml.ui.targetmanager.TargetManager;
import org.tigris.gef.undo.UndoableAction;
@@ -57,7 +58,7 @@
private static UndoableAction actionNewToDoItem = new ActionNewToDoItem();
    private static UndoableAction actionResolve = new ActionResolve();
private static UndoableAction actionEmailExpert = new ActionEmailExpert();
-    private static UndoableAction actionSnooze = new ActionSnooze();
+    private static ToDoItemAction actionSnooze = new ActionSnooze();
    //public static UMLAction _actionRecordFix = Actions.RecordFix;
    //public static UMLAction _actionReplayFix = Actions.ReplayFix;
    //public static UMLAction _actionFixItNext = Actions.FixItNext;
@@ -170,6 +171,7 @@
            showDescription();
        }
        updateActionsEnabled();
+        actionSnooze.updateEnabled(item);
    }

   /**


----- Original Message ----- From: "Niro" <[EMAIL PROTECTED]>
To: <[email protected]>
Sent: Tuesday, July 11, 2006 4:22 PM
Subject: [argouml-dev] Critics problems


Hi all,
I'm currently working on the Critique subsystem... and I'm having lots of problems :-/

- I can't make the "snooze critic" feature work. No way. There's a "snooze critic" button in the ToDoItem tab: pressing it never works. AFAICS, the [ActionSnooze.]actionPerformed() method checks if the [ToDoItemAction.]rememberedTarget is a ToDoItem instance.... I still haven't found a way to set this attribute. The only method that can modify it is [ToDoItemAction.]updateEnabled(): but it has no reference in the workspace.... Anyway, having a button that keeps being enabled without any user feedback is not good... I think I should post an enhancement issue

- Have a look at the "Brows Critics" box (menu Critique --> Browse Critics). The buttons on the right side of the window are never enabled, even if I deactivate a critic with the checkboxes on the left. Could this be a side effect of the problem described above?

Regards, Andrea

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



--
No virus found in this incoming message.
Checked by AVG Free Edition.
Version: 7.1.394 / Virus Database: 268.9.10/384 - Release Date: 10/07/2006





--
No virus found in this outgoing message.
Checked by AVG Free Edition.
Version: 7.1.394 / Virus Database: 268.9.10/384 - Release Date: 10/07/2006

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to