This is well after the fact, but a few comments on this change: - I doubt that moving a class from one class to another can remove a dependency cycle. At best it can change things so that the cycle is entirely contained within a package. Smaller cycles are better, but we should really be striving to remove them.
- Moving classes between packages is essentially the same as renaming them and is an incompatible API change. These changes broke ArgoEclipse when committed and will break any other external consumers. - Having the ProgressMonitor interface reside in the org.argouml.swingext package is very misleading since it's entire purpose in life is to decouple ArgoUML from a hard dependency on javax.swing.ProgressMonitor (which is what was used originally). It is specifically intended to be independent of Swing and SWT. Tom > -----Original Message----- > From: Michiel van der Wulp [mailto:[EMAIL PROTECTED] > Sent: Thursday, April 19, 2007 1:32 PM > To: [email protected] > Subject: [argouml-dev] Refactor Configuration to remove > cyclic dependency > > To remove the cyclic dependency between > org.argouml.application.api and > org.argouml.application.configuration, > I'd like to move the 2 classes Configuration and > ConfigurationKey from the > former to the latter package. > > This means adapting many files, also in many sub-projects of > ArgoUML, since > the Configuration is often used. > > Since this is such a large scale change, and involves many > sub-projects of > ArgoUML, I'd like some input. Please react if there are > remarks on this > change! > Without any protest, I will perform this change tomorrow. > > Regards, > Michiel --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
