[argouml-dev] Init of Tabs (Was: svn commit: r13783 - trunk/src_new/org/argouml/util/ConfigLoader.java)

[Michiel van der Wulp]

Hi Tom,
I like the changes you did. Well done!




How about the attached patch?


Regards,
Michiel




To: "Michiel van der Wulp" <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Sent: Wednesday, November 21, 2007 12:09 AM

But I would like to go a bit further now to solve a dependency problem, such as org.argouml.ui.DetailsPane depends on org.argouml.cognitive.checklist.ui.TabChecklist, which it shouldn't (you removed the test that enforced it). This way, the Main class puts the UI together from otherwise independent subsystems. ----- Original Message ----- From: "Tom Morris" <[EMAIL PROTECTED]> Subject: Re: svn commit: r13783 - trunk/src_new/org/argouml/util/ConfigLoader.java

On Nov 20, 2007 12:55 PM, Michiel van der Wulp <[EMAIL PROTECTED]> wrote:

This commit creates a package dependency cycle which breaks the unit tests.

The dependency to remove is from org.argouml.util to
org.argouml.uml.ui.TabProps

I didn't add any new dependencies, but I did make some of the ones
that were there already visible.  This was coded as follows (which I'm
guessing your tool doesn't detect):

                                   if (className.equals(

                                       tabPropsOrientation = orientation;

"org.argouml.uml.ui.TabProps")) {

I presume it is your intention to remove the whole class (with which I fully

agree), so how do we fix the failing test?

Strictly speaking, the code caching the orientation needs to stay for
backward compatibility as long as we support the deprecated methods.
However, I think ArgoUML always creates property panels in the
Horizontal orientation, so we could just hard code the return value
for the compatibility period.

IMHO we should initialise the panels in the Main class, since it is in a top

package.
The ConfigLoader.loadTabs is used in 2 locations only, so I could work on
replacing this by direct initialising the panels from
org.argouml.application.

Actually I think each panel should be responsible for initializing
itself.  I've replicated the information from argo.ini in the
appropriate classes so that the dependencis are visible.  It's trivial
to actually do the initialization there as well, but I was doing
things in a step-wise fashion.

Are you doing this? Shall I?

I'll finish the initialization work.  That will most likely break the
cycle, but there will still be a "wrong way" dependency from util to
the property panels until we make a decision on the fate of the
orientation method.

Tom


--
No virus found in this incoming message.
Checked by AVG Free Edition.

Version: 7.5.503 / Virus Database: 269.16.1/1141 - Release Date: 20/11/2007 11:34

dependency.patch
Description: Binary data

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]