> The idea of ExtendedImportInterface might be obvious, I'm doing an > 'instanceof' against this now. ImportCommandInterface is for the > callback from the import module to invoke Import.doFile().
I think the norm is to introduce version numbers on interfaces, e.g. ImportInterface2, otherwise what happens with future extensions? ExtendedExtendedImportInterface? Alternatively just introduce a non-extended interface that describes its purpose more specifically (eg ImportInvoker) and have the relevant class implement that also. Bob. > > I'll have a look into the new issue, Tom, and also on ImportSettings, > but I'm short of time now. Anyway, do you (both) think the new approach > is better? > > > Thanks for your comments, > Thomas > > -------- Original-Nachricht -------- >> Datum: Mon, 2 Jun 2008 11:08:17 -0400 >> Von: "Tom Morris" <[EMAIL PROTECTED]> >> An: [email protected] >> Betreff: Re: [argouml-dev] Caution: ImportInterface extended! > >> On Mon, Jun 2, 2008 at 10:17 AM, alexander krohn <[EMAIL PROTECTED]> >> wrote: >> >> > i can think of different options for the python-module, which would be >> nice >> > to have >> > >> > - identifieng different python-installs, value would be a path. >> > - additional module-paths(includes), value would a a list of pathes. >> >> Sounds like filesystem path and (ordered) list of paths would be >> useful additions to the settings. I've created issue 5123 for this >> enhancement request. >> >> The current setting types are defined in >> org.argouml.uml.reveng.SettingsTypes and include boolean, multiple >> choice, and string. We could use String currently, but the user >> wouldn't have any assistance in browsing the file system. >> >> > - usage of environment-variable PYTHON, a boolean >> > these are more or less python-specific. >> >> We already have a boolean. >> >> > more basic options, which should be available per default: >> > - file(s) to import >> > - recursive directory-import, a boolean. >> >> This is all handled by the driver framework. All the importer sees is >> a list of files to process. If the user selects recursive import, >> this will be resolved to a list of files before control is passed to >> the importer. >> >> > ImportSettings could be pimped to have name, value and description for >> an >> > import-option, but where to apply l10n? >> >> Localization has to happen in the import module because it's the only >> one who knows what's in the strings. >> >> Tom >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] > > -- > GMX startet ShortView.de. Hier findest Du Leute mit Deinen Interessen! > Jetzt dabei sein: http://www.shortview.de/[EMAIL PROTECTED] > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
