Hi Michiel,
It would have been better to discuss this on the dev list, to sollicit more design ideas.
Yes it would have!
Can you please point what interface/abstract class I should modify in order to have a public int getVisibilityOffset() method in every notation ?
That would be the NotationName interface, and then you can implement it in NotationNameImpl. You will also need a setter - so that all notations (e.g. C++) can set this value, and a reasonable default value.
Maybe each notation should be able to switch this feature off?
I'll put this in the interface and implement it in the required notations. This could be easily switched off with an offset of 0.
But I do have another problem with this value! What is it exactly used for? (I did not read all the code.) Did you take into account the font size? If your values work for the default size 10, then it won't on my PC, where I use size 16.
The value is the approximate width in pixels (default font size) of the +/-/~/# signs and the public/private/protected words to identify where the user clicked. The visibility is cycled only if the click is on the sign or on the word.
Why not make it a separate UI widget, then you will be able to detect hits easily, and size independently. This will then work a bit like entering stereotypes on class names: You can enter them in fronnt of the name, but they will appear above them. Double clicking on the name allows you to add another...
I would consider showing the visibility in a separate widget.
On a usability point of view I find it very comfortable only clicking the sign/word to cycle visibility. No need to add and charge the class Fig. If you have 2 mins to try the feature it would be great. You could see how easy it is. Computing the size of the offset could be done in the method and there we could take into account the size of the font.
Maybe Bob has an opinion on this.
Bob ?

Regards,
Michiel
Regards,
Bogdan

--
Bogdan SZANTO
-----------------------------------------------
Impossible is nothing ~ Nothing is impossible !
-----------------------------------------------


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to