Maybe not relevant to this specific proposal but a comment on what I
see of how notations are defined.
NotationProviderFactory2 npf = NotationProviderFactory2.getInstance();
NotationName nn = Notation.findNotation("UML 1.4");
npf.addNotationProvider(NotationProviderFactory2.TYPE_SD_MESSAGE,
nn, SDMessageNotationUml.class);
The use of SDMessageNotationUml.class here makes me assume that at
some later point an instance of SDMessageNotationUml is created by
reflection.
I find reflection tends to hide the true relationships between classes.
Is there any change of introducing a factory for this instead.
interface NotationFactory {
NotationProvider createNotation();
}
class SDMessageNotationUmlFactory implements NotationFactory {
NotationProvider createNotation() {
return new SDMessageNotationUml();
}
}
The code above can then become as below with the factory being called
later instead of reflection being used.
NotationProviderFactory2 npf = NotationProviderFactory2.getInstance();
NotationName nn = Notation.findNotation("UML 1.4");
npf.addNotationProvider(NotationProviderFactory2.TYPE_SD_MESSAGE,
nn, new SDMessageNotationUmlFactory());
Regards
Bob.
2008/12/18 Tom Morris <[email protected]>:
> It looks like I misunderstood Michiel's position on this and he is not
> opposed to the proposed design.
>
> If anyone else has feedback on the proposal, please provide it ASAP.
>
> Tom
>
> ------------------------------------------------------
> http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=986713
>
> To unsubscribe from this discussion, e-mail:
> [[email protected]].
>
------------------------------------------------------
http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=986835
To unsubscribe from this discussion, e-mail:
[[email protected]].
