Author: bobtarling Date: 2011-05-11 11:28:28-0700 New Revision: 19411 Modified: trunk/src/argouml-app/src/org/argouml/uml/cognitive/critics/ProfileCodeGeneration.java trunk/src/argouml-app/src/org/argouml/uml/cognitive/critics/ProfileGoodPractices.java
Log: Drop critics from UML2 that rely on UML1.4 Modified: trunk/src/argouml-app/src/org/argouml/uml/cognitive/critics/ProfileCodeGeneration.java Url: http://argouml.tigris.org/source/browse/argouml/trunk/src/argouml-app/src/org/argouml/uml/cognitive/critics/ProfileCodeGeneration.java?view=diff&pathrev=19411&r1=19410&r2=19411 ============================================================================== --- trunk/src/argouml-app/src/org/argouml/uml/cognitive/critics/ProfileCodeGeneration.java (original) +++ trunk/src/argouml-app/src/org/argouml/uml/cognitive/critics/ProfileCodeGeneration.java 2011-05-11 11:28:28-0700 @@ -43,6 +43,7 @@ import org.argouml.cognitive.CompoundCritic; import org.argouml.cognitive.Critic; +import org.argouml.model.Model; import org.argouml.profile.Profile; /** @@ -108,7 +109,9 @@ critics.add(crDisambigClassName); critics.add(new CrIllegalName()); critics.add(new CrReservedName()); - critics.add(new CrNoInitialState()); + if (Model.getFacade().getUmlVersion().startsWith("1")) { + critics.add(new CrNoInitialState()); + } critics.add(new CrNoTriggerOrGuard()); critics.add(new CrNoGuard()); Modified: trunk/src/argouml-app/src/org/argouml/uml/cognitive/critics/ProfileGoodPractices.java Url: http://argouml.tigris.org/source/browse/argouml/trunk/src/argouml-app/src/org/argouml/uml/cognitive/critics/ProfileGoodPractices.java?view=diff&pathrev=19411&r1=19410&r2=19411 ============================================================================== --- trunk/src/argouml-app/src/org/argouml/uml/cognitive/critics/ProfileGoodPractices.java (original) +++ trunk/src/argouml-app/src/org/argouml/uml/cognitive/critics/ProfileGoodPractices.java 2011-05-11 11:28:28-0700 @@ -42,6 +42,7 @@ import java.util.Set; import org.argouml.cognitive.Critic; +import org.argouml.model.Model; import org.argouml.profile.Profile; /** @@ -80,7 +81,9 @@ critics.add(new CrTooManyAttr()); critics.add(new CrTooManyOper()); critics.add(new CrTooManyTransitions()); - critics.add(new CrTooManyStates()); + if (Model.getFacade().getUmlVersion().startsWith("1")) { + critics.add(new CrTooManyStates()); + } critics.add(new CrTooManyClasses()); critics.add(new CrWrongLinkEnds()); critics.add(new CrUtilityViolated()); ------------------------------------------------------ http://argouml.tigris.org/ds/viewMessage.do?dsForumId=5905&dsMessageId=2734462 To unsubscribe from this discussion, e-mail: [[email protected]].
