Author: bobtarling
Date: 2011-05-15 11:34:44-0700
New Revision: 19431

Modified:
   
trunk/src/argouml-core-umlpropertypanels/src/org/argouml/core/propertypanels/ui/UMLValueSpecificationPanel.java

Log:
Add TODO comment regarding reflection

Modified: 
trunk/src/argouml-core-umlpropertypanels/src/org/argouml/core/propertypanels/ui/UMLValueSpecificationPanel.java
Url: 
http://argouml.tigris.org/source/browse/argouml/trunk/src/argouml-core-umlpropertypanels/src/org/argouml/core/propertypanels/ui/UMLValueSpecificationPanel.java?view=diff&pathrev=19431&r1=19430&r2=19431
==============================================================================
--- 
trunk/src/argouml-core-umlpropertypanels/src/org/argouml/core/propertypanels/ui/UMLValueSpecificationPanel.java
     (original)
+++ 
trunk/src/argouml-core-umlpropertypanels/src/org/argouml/core/propertypanels/ui/UMLValueSpecificationPanel.java
     2011-05-15 11:34:44-0700
@@ -117,6 +117,19 @@
        UMLValueSpecificationValueField ret = null;
 
        try {
+           // TODO: Bob says the reflective code following should be replaced
+           // with something more specific like this commented out code.
+           // This would mean we need sType changed to a meta type Object
+           // rather than a String.
+           
+//         if (Model.getFacade().isALiteralBoolean(sType)) {
+//             fieldControl = new 
UMLValueSpecificationValueFieldLiteralBoolean(model, true);
+//         } else if (Model.getFacade().isALiteralString(sType)) {
+//             fieldControl = new 
UMLValueSpecificationValueFieldLiteralString(model, true);
+//         } else if (Model.getFacade().isAOpaqueExpression(sType)) {
+//             fieldControl = new 
UMLValueSpecificationValueFieldLiteralString(model, true);
+//         }       
+           
            Class<?> oClass= 
Class.forName("org.argouml.core.propertypanels.ui.UMLValueSpecificationValueField"+sType);
            Constructor<?> constructeur = oClass.getConstructor (new Class [] 
{UMLValueSpecificationModel.class,boolean.class});
            ret=(UMLValueSpecificationValueField) constructeur.newInstance (new 
Object [] {model, true});

------------------------------------------------------
http://argouml.tigris.org/ds/viewMessage.do?dsForumId=5905&dsMessageId=2737598

To unsubscribe from this discussion, e-mail: 
[[email protected]].

Reply via email to