Hi Laurent, after inspecting the code (including the built-in modules) I see no problem in changing getTaggedValueValue so that it returns "" in eUML too. The core ArgoUML code doesn't use getTaggedValueValue btw., but the Java code generator would benefit from that change, too. Also I've seen the SQL module using it, but I've not inspected it further. UML2 for modules is not a started task, so no problem.
Is there an issue record for your found problem? I'd commit your proposed patch immediately then and mark the issue fixed. Any further comments? Thomas -------- Original-Nachricht -------- > Datum: Thu, 21 Jul 2011 05:31:15 -0700 (PDT) > Von: Laurent BRAUD <[email protected]> > An: [email protected] > Betreff: [argouml-dev] UML2 (and ArgoPrint) : Tagged Value > Hi, > When I launch ArgoPrint with UML2, we have in file > "$DiagramUtil.getMemberDescription" instead of "" for UML > > The getTaggedValueValue return "" with UML1, but it return null with UML2 > > 2 choices (I think): > - Change the getTaggedValueValue in UML2 > - Change Argoprint in order to have "" when null is return. > > > getTaggedValueValue is used in other module. So, do we need to change in > all modules (if needed) > Is there a problem if we put "" instead of null ? (See comment: <> from > UML1, but for null or for something else) > > > Class : org.argouml.model.euml > > public String getTaggedValueValue(Object handle, String name) { > // usage differs from UML1 > Object tv = getTaggedValue(handle, name); > return tv != null ? tv.toString() : ""; //$NON-NLS-1$ > } > > ------------------------------------------------------ > http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=2800063 > > To unsubscribe from this discussion, e-mail: > [[email protected]]. > To be allowed to post to the list contact the mailing list moderator, > email: [[email protected]] ------------------------------------------------------ http://argouml.tigris.org/ds/viewMessage.do?dsForumId=450&dsMessageId=2800187 To unsubscribe from this discussion, e-mail: [[email protected]]. To be allowed to post to the list contact the mailing list moderator, email: [[email protected]]
