[
https://issues.apache.org/jira/browse/ARIA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15801396#comment-15801396
]
ASF GitHub Bot commented on ARIA-56:
------------------------------------
Github user ran-z commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/42#discussion_r94770242
--- Diff: tests/storage/test_models.py ---
@@ -664,6 +664,72 @@ def test_node_instance_model_creation(self,
node_storage, is_valid, name, runtim
assert node_instance.deployment ==
node_storage.deployment.list()[0]
+class TestNodeInstanceIP(object):
+
+ ip = '1.1.1.1'
+
+ def test_ip_on_none_hosted_node_instance(self, deployment_storage):
--- End diff --
I'd also add a test where the instance in question is not a host but the
host does have IP (say as runtime property) and verify the IP is returned.
technically speaking its the same code path as
"test_runtime_property_ip_on_hosted_node_instance", but it's a common use case
and we should verify it as well
> API for retrieving a node's host IP
> -----------------------------------
>
> Key: ARIA-56
> URL: https://issues.apache.org/jira/browse/ARIA-56
> Project: AriaTosca
> Issue Type: Story
> Reporter: Ran Ziv
> Assignee: Dan Kilman
>
> The node instance's model object should have an "ip" property which will
> retrieve either its IP or its host node instance's IP
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
