[ 
https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858118#comment-15858118
 ] 

ASF GitHub Bot commented on ARIA-42:
------------------------------------

Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/68#discussion_r100072787
  
    --- Diff: aria/storage/core.py ---
    @@ -52,11 +55,21 @@ class Storage(LoggerMixin):
         """
         Represents the storage
         """
    -    def __init__(self, api_cls, api_kwargs=None, items=(), **kwargs):
    +    def __init__(self,
    +                 api_cls,
    +                 items=(),
    --- End diff --
    
    add api_kwargs and move init, init_kwargs to ModelStorage (and rename init 
to session_initiator)


> Implement full blown mechanism for serializing an operation context
> -------------------------------------------------------------------
>
>                 Key: ARIA-42
>                 URL: https://issues.apache.org/jira/browse/ARIA-42
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Dan Kilman
>            Assignee: Maxim Orlov
>
> The current mechanism at 
> aria/orchestration/workflows/context/serialization.py is very limited.
> It serializes/deserializes the context.model and context.resource with hard 
> coded knowledge of the actual implementation involved and even how they were 
> initialized. Specifically:
> The model storage initialized is always expected to be sqlachemy based with 
> no additional engine configuration (i.e. only the engine url is used to 
> re-construct the sqlalchemy engine), similar logic applies to the 
> instantiated sqlalchemy session.
> The resource storage initialized is always the file based resource storage.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to