Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/69#discussion_r102234412
  
    --- Diff: aria/logger.py ---
    @@ -135,5 +142,37 @@ def create_file_log_handler(
         return rotating_file
     
     
    +class _SQLAlchemyHandler(logging.Handler):
    +
    +    def __init__(self, session, engine, **kwargs):
    +        logging.Handler.__init__(self, **kwargs)
    +        self._session = session
    +        self._engine = engine
    +
    +        # Cyclic dependency
    +        from aria.storage.modeling.model import Log
    +        self._cls = Log
    +
    +    def emit(self, record):
    +        # pylint fails to recognize that this class does indeed have 
__table__
    +        self._cls.__table__.create(bind=self._engine, checkfirst=True)     
                         # pylint: disable=no-member
    --- End diff --
    
    move no-member to rules (for code and tests).
    
    Check if indeed recreation is necessary 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to