[ 
https://issues.apache.org/jira/browse/ARIA-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907438#comment-15907438
 ] 

ASF GitHub Bot commented on ARIA-105:
-------------------------------------

Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/72#discussion_r105652210
  
    --- Diff: aria/modeling/mixins.py ---
    @@ -67,9 +108,9 @@ def foreign_key(cls, parent_table, nullable=False):
                           nullable=nullable)
     
         @classmethod
    -    def relationship_to_self(cls,
    -                             column_name,
    -                             relationship_kwargs=None):
    +    def _create_relationship_to_self(cls,
    --- End diff --
    
    why did it turn to create? this implies that each time i call any method 
which utilizes this helper function i'll create a new relationship. Furthermore 
why is it a private method.


> Integrate new models into parser
> --------------------------------
>
>                 Key: ARIA-105
>                 URL: https://issues.apache.org/jira/browse/ARIA-105
>             Project: AriaTosca
>          Issue Type: Task
>            Reporter: Ran Ziv
>            Assignee: Tal Liron
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to