Hi DJ, A lot has changed since August. :) I wonder if you can take a look at the current state of master and see if things have improved with wagon installs?
On Fri, Dec 1, 2017 at 9:22 AM, D Jayachandran <d.jayachand...@ericsson.com> wrote: > Hi Ran, > > Sorry I had missed to answer this thread. Just to answer your question > wagon also expects pip as a binary "/usr/bin/pip". The above path may not > be the same for al distros of linux and when the path varies we run into > the issue/ > As I already told we could probably fix this issue by using pip as library > instead of a 3PP. > Please let me know if we can also apply the same fix with wagon as well. > > Regards, > DJ > -----Original Message----- > From: Ran Ziv [mailto:r...@cloudify.co] > Sent: Sunday, August 20, 2017 12:40 PM > To: dev@ariatosca.incubator.apache.org > Subject: Re: pip executable expected as part of plugin install. > > Can you try to explain again what's the issue you're seeing with the way > Wagon works right now? > We could create a pull request for Wagon as well, but I'm not sure I > understand the problem at the moment. > > On Wed, Aug 16, 2017 at 6:04 PM, D Jayachandran < > d.jayachand...@ericsson.com > > wrote: > > > Even if we fix the issue in ARIA. Wagon library still uses the same > > logic in finding the pip path and it is wrong. > > Am not sure how to fix this with wagon. > > > > Regards, > > DJ > > -----Original Message----- > > From: D Jayachandran [mailto:d.jayachand...@ericsson.com] > > Sent: Thursday, August 03, 2017 5:00 PM > > To: dev@ariatosca.incubator.apache.org > > Subject: RE: pip executable expected as part of plugin install. > > > > Thanks Avia, I will open an issue. > > > > Regards, > > DJ > > > > -----Original Message----- > > From: Avia Efrat [mailto:a...@cloudify.co] > > Sent: Thursday, August 03, 2017 4:01 PM > > To: dev@ariatosca.incubator.apache.org > > Subject: Re: pip executable expected as part of plugin install. > > > > Hi DJ, > > It seems you are correct, I don't see a reason for not using the pip > > library. > > Maybe it was that way since we didn't want to add pip as a dependency > > explicitly (this code is from the beginning of ARIA). > > > > Feel free to open an issue about that =) > > > > On Wed, Aug 2, 2017 at 10:19 AM, D Jayachandran < > > d.jayachand...@ericsson.com > > > wrote: > > > > > Hi, > > > > > > Am using a Ubuntu version of linux for my development and ARIA does > > > not find the correct path of pip during the plugin install. > > > To be precise this happens when pip freeze is executed. > > > > > > @staticmethod > > > def _pip_freeze(): > > > """Run pip freeze in current environment and return the > output""" > > > bin_dir = 'Scripts' if os.name == 'nt' else 'bin' > > > pip_path = os.path.join(sys.prefix, bin_dir, > > > 'pip{0}'.format('.exe' if os.name == > > 'nt' > > > else '')) > > > pip_freeze = subprocess.Popen([pip_path, 'freeze'], > > > stdout=subprocess.PIPE) > > > pip_freeze_output, _ = pip_freeze.communicate() > > > assert not pip_freeze.poll() > > > return pip_freeze_output > > > > > > Now the question is why are we executing a pip command directly and > > > not using pip as a library. > > > > > > > > > Regards, > > > DJ > > > > > >
