Tim, John,
Using tim's patch and making the following change(adding
@SuppressWarnings) for deprecated api, subsystem.core building is
successful on jdk7.
@SuppressWarnings("deprecation")
public String toString() {
StringBuilder builder = new StringBuilder("subsystem://");
if (url != null) {
try {
builder.append(URLEncoder.encode(url.toString(), "UTF-8"));
} catch (UnsupportedEncodingException e) {
builder.append(URLEncoder.encode(url.toString()));
}
}
...
Thanks
--Tang
Tang Yong wrote:
> Hi Tim, John
>
> I have found and tried the patch, and although subsystem core module's
> building still failed,
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile
> (default-compile) on project org.apache.aries.subsystem.core:
> Compilation failure
> [ERROR]
> D:\aries\subsystem\subsystem-core\src\main\java\org\apache\aries\subsystem\core\internal\SubsystemUri.java:[90,29]
> 警告:[deprecation] URLEncoderのencode(String)は推奨されません
> [ERROR] -> [Help 1]
> [ERROR]
>
> however, this time, previous an error dispeared:
> "
> [ERROR] could not parse error message: 警告:[options] ブートストラップ・
> クラスパスが-source 1.6と一緒に設定されていません"
>
> So, I suggest that we'd better remove URLEncoder.encode(String) in
> SubsystemUri and I do not recommend on such coding.
>
> Thanks
> --Tang
>
> Timothy Ward wrote:
>> Hi Tang,
>> It's not a complete solution, but it was posted to the mailing list with the
>> subject "Compiling with Java 7"
>> Regards
>>
>> Tim Ward
>> -------------------
>> Apache Aries PMC member & Enterprise OSGi advocate
>> Enterprise OSGi in Action (http://www.manning.com/cummins)
>> -------------------
>>
>>
>>> Date: Fri, 3 May 2013 22:02:23 +0900
>>> From: [email protected]
>>> To: [email protected]
>>> Subject: Re: [jira] [Commented] (ARIES-1061) make subsystem core can be
>>> built on jdk7
>>>
>>> Tim
>>>
>>> could you tell me the position of your patch posted and I want to look
>>> it, then make a confirmation on my env.
>>>
>>> Thanks
>>> --Tang
>>>
>>> Timothy Ward wrote:
>>>> I'm not sure I see the need for a Java7 parent yet. We're not planning to
>>>> start targeting binaries for Java 7, we still want to support Java 6 (and
>>>> possibly Java 5 for some people). What we need to do is to update the Java
>>>> 5 and Java 6 parents so that they can compile successfully when using a
>>>> Java 7 VM.
>>>> I posted a patch with a prototype for this in it yesterday - has anyone
>>>> had a chance to look?
>>>>
>>>> Tim Ward
>>>> -------------------
>>>> Apache Aries PMC member & Enterprise OSGi advocate
>>>> Enterprise OSGi in Action (http://www.manning.com/cummins)
>>>> -------------------
>>>>
>>>>
>>>>> Date: Fri, 3 May 2013 12:22:16 +0000
>>>>> From: [email protected]
>>>>> To: [email protected]
>>>>> Subject: [jira] [Commented] (ARIES-1061) make subsystem core can be built
>>>>> on jdk7
>>>>>
>>>>>
>>>>> [
>>>>> https://issues.apache.org/jira/browse/ARIES-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648360#comment-13648360
>>>>> ]
>>>>>
>>>>> John Ross commented on ARIES-1061:
>>>>> ----------------------------------
>>>>>
>>>>> The think the real cause of the execution failure is a cross compiler
>>>>> issue as described here:
>>>>> http://docs.oracle.com/javase/7/docs/technotes/tools/windows/javac.html#crosscomp-example.
>>>>> I'll bet the translation of that error message amounts to "warning:
>>>>> [options] bootstrap class path not set in conjunction with -source 1.6".
>>>>>
>>>>> The solution appears to be to use -DcompileSource=1.7 when building. For
>>>>> example, "mvn clean install -DcompileSource=1.7".
>>>>>
>>>>> Generally speaking, I think Apache Aries needs to define a java7-parent
>>>>> before we can begin making any statements in terms of supporting source
>>>>> code builds against java 7. A more serious issue would be if the source
>>>>> compiled against java6-parent does not run on java 7.
>>>>>
>>>>>> make subsystem core can be built on jdk7
>>>>>> ----------------------------------------
>>>>>>
>>>>>> Key: ARIES-1061
>>>>>> URL: https://issues.apache.org/jira/browse/ARIES-1061
>>>>>> Project: Aries
>>>>>> Issue Type: Improvement
>>>>>> Components: Subsystem
>>>>>> Affects Versions: 1.0
>>>>>> Environment: JDK7
>>>>>> Reporter: TangYong
>>>>>> Priority: Minor
>>>>>> Attachments: SubsystemUri.java.patch
>>>>>>
>>>>>>
>>>>>> Currently, a fact that subsystem core can not be built on jdk7 has
>>>>>> caused the whole subsystem can not be built on jdk7 platform. Seeing the
>>>>>> following exception:
>>>>>> ...
>>>>>> [ERROR] Failed to execute goal
>>>>>> org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile
>>>>>> (default-compile) on project org.apache.aries.subsystem.core:
>>>>>> Compilation failure
>>>>>> [ERROR] could not parse error message: 警告:[options]
>>>>>> ブートストラップ・クラスパスが-source 1.6と一緒に設定されていません
>>>>>> [ERROR]
>>>>>> D:\aries\subsystem\subsystem-core\src\main\java\org\apache\aries\subsystem\core\internal\SubsystemUri.java:90:
>>>>>> 警告:[deprecation] URLEncoderのencode(String)は推奨されません
>>>>>> [ERROR] builder.append(URLEncoder.encode(url.toString()));
>>>>>> [ERROR] ^
>>>>>> [ERROR] -> [Help 1]
>>>>>> [ERROR]
>>>>>> ...
>>>>>> The reason is very simple,
>>>>>> builder.append(URLEncoder.encode(url.toString())); has been deprecated
>>>>>> and blocked compiling.
>>>>> --
>>>>> This message is automatically generated by JIRA.
>>>>> If you think it was sent incorrectly, please contact your JIRA
>>>>> administrators
>>>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>>>
>>> --
>>> −−−−−−−−−−−−−−−−−−−−−−
>>> Tang Yong
>>> Senior Engineer
>>> Glassfish Team Developer(OSGi&OSGi-JavaEE)
>>> OSGi Alliance Supporter
>>> Blog: http://osgizone.typepad.com/tangyong/
>>>
>>> Nanjing Fujitsu NanDa Software Tec CO.,LTD
>>> http://www.fujitsu.com/cn/fnst
>>> Tel: +86-25-86630566-8310
>>> Fax: +86-25-83317685
>>> −−−−−−−−−−−−−−−−−−−−−−
>>>
>>
>
--
−−−−−−−−−−−−−−−−−−−−−−
Tang Yong
Senior Engineer
Glassfish Team Developer(OSGi&OSGi-JavaEE)
OSGi Alliance Supporter
Blog: http://osgizone.typepad.com/tangyong/
Nanjing Fujitsu NanDa Software Tec CO.,LTD
http://www.fujitsu.com/cn/fnst
Tel: +86-25-86630566-8310
Fax: +86-25-83317685
−−−−−−−−−−−−−−−−−−−−−−
