[ 
https://issues.apache.org/jira/browse/ARIES-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996462#comment-13996462
 ] 

ASF GitHub Bot commented on ARIES-1188:
---------------------------------------

GitHub user cschneider opened a pull request:

    https://github.com/apache/aries/pull/10

    ARIES-1188 Remove pax exam dependency and make testsupport compatible to...

    Remove pax exam dependency and make testsupport compatible to pax exam 3

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cschneider/aries trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/aries/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit f950c30b43b5b1151d9a0f19b80c2a4469c0c596
Author: Christian Schneider <ch...@die-schneider.net>
Date:   2014-05-13T14:56:16Z

    ARIES-1188 Remove pax exam dependency and make testsupport compatible to 
pax exam 3

----


> Remove pax exam dependency from org.apache.aries.testsupport.unit
> -----------------------------------------------------------------
>
>                 Key: ARIES-1188
>                 URL: https://issues.apache.org/jira/browse/ARIES-1188
>             Project: Aries
>          Issue Type: Improvement
>            Reporter: Christian Schneider
>
> Like described in 
> http://mail-archives.apache.org/mod_mbox/aries-dev/201405.mbox/%3C5370E1EA.9040008%40die-schneider.net%3E
> I propose to remove the pax exam dependency from 
> org.apache.aries.testsupport.unit. So some reasons why I think this makes 
> sense:
> - testsupport is used in many aries projects. Many of these do not need the 
> pax exam depdenency. So the dependency binds all these project to a 
> particular pax exam version and increases coupling
> - pax exam is only needed for two classes in test support. ExtraOptions and 
> AbstractIntegrationTest. ExtraOptions is not really necessary with newer pax 
> exam versions as most of the features are available directly in the pax exam 
> DSL. AbstractIntegrationTest just uses the pax exam @Inject. In pax exam 3 
> this is replaced with javax @Inject. So this dependency is not necessary 
> anymore.
> As far as I know this means we need a new major version of testsupport as we 
> remove a public class.
> I will provide a patch.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to