[
https://issues.apache.org/jira/browse/ARIES-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329389#comment-15329389
]
Wouter Bancken edited comment on ARIES-1564 at 6/14/16 12:18 PM:
-----------------------------------------------------------------
[~jwr...@us.ibm.com]
I added a commit to the pull request. The commit uses the triple
symbolicName_version_type as key for the start order map.
Since the Subsystem-Content header contains version ranges for the resources,
the start order map can only be used for exact version ranges.
If no value is found in the map (because the bundle was not mentioned in the
Subsystem-Content header or because a non-exact version range was used), the
implementation defaults to the original retrieval of the startorder.
This will cause an improvement in startup when:
- Exact version ranges are used in the Subsystem-Content header
- The Subsystem-Content header contains the bundles included in the artifact.
The effect of this change for our application will be even more noticeable
after ARIES-1490 which will allow us to specify our transitive dependencies in
the Subsystem-Content header.
was (Author: wouter bancken):
[~jwr...@us.ibm.com]
I added a commit to the pull request. The commit uses the triple
symbolicName_version_type as key for the start order map.
Since the Subsystem-Content header contains version ranges for the resources,
the start order map can only be used for exact version ranges.
If no value is found in the map (because the bundle was not mentioned in the
Subsystem-Content header or because a non-exact version range was used), the
implementation defaults to the original retrieval of the startorder.
This will cause an improvement in startup when:
- Exact version ranges are used in the Subsystem-Content header
- The Subsystem-Content header contains the bundles contained in the artifact.
The effect of this change for our application will be even more noticeable
after ARIES-1490 which will allow us to specify our transitive dependencies in
the Subsystem-Content header.
> Performance improvement: sorting bundles by start-level is done eagerly
> -----------------------------------------------------------------------
>
> Key: ARIES-1564
> URL: https://issues.apache.org/jira/browse/ARIES-1564
> Project: Aries
> Issue Type: Improvement
> Components: Subsystem
> Affects Versions: subsystem-2.0.8
> Reporter: Wouter Bancken
>
> h4. Description
> During sorting in the StartAction class, the SubsystemContentHeader is parsed
> every time the start order of a bundle is needed. By eagerly parsing the
> header and storing the start value for every bundle, an improved startup time
> can be achieved.
> h4. Pull request
> https://github.com/apache/aries/compare/subsystem-2.0.x...WouterBanckenACA:sorting_performance_optimalisation
> h4. Mailinglist
> http://mail-archives.apache.org/mod_mbox/aries-user/201606.mbox/%3CCAL5nZgRQcvFqz8g1c7mKJ3C_UoRmRox10%2BOM2uEjRbCkTYodDQ%40mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
