[ 
https://issues.apache.org/jira/browse/ARIES-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939979#comment-15939979
 ] 

Guillaume Nodet commented on ARIES-1707:
----------------------------------------

Thx for the patch !  One test was failing though... ;-)

> The BlueprintMetadata.getBlueprintContainer throws inconsistent exceptions
> --------------------------------------------------------------------------
>
>                 Key: ARIES-1707
>                 URL: https://issues.apache.org/jira/browse/ARIES-1707
>             Project: Aries
>          Issue Type: Bug
>          Components: JMX
>            Reporter: Hao Zhong
>            Assignee: Guillaume Nodet
>             Fix For: jmx-1.2.0
>
>         Attachments: aries.patch
>
>
> The BlueprintMetadata_getBlueprintContainer method throws 
> IllegalArgumentException as follow:
> {code:title=BlueprintMetadata.java|borderStyle=solid}
>  if (serviceReferences == null || serviceReferences.length <1) {
>             throw new IllegalArgumentException("Invalid BlueprintContainer 
> service id: " + containerServiceId);
>         }
> {code}
> However, the FrameworkUtils_resolveService method throws IOException for the 
> same condition:
> {code:title=FrameworkUtils.java|borderStyle=solid}
> if (references == null || references.length < 1) {
>                 throw new IOException("Service with id [" + serviceId + "] 
> not found");
>             } else {
>                 result = references[0];
>             }
> {code}
> This is confusing. Indeed, I notice that the buggy code of ARIES-333 throws 
> IllegalArgumentException, but the fixed code throws IOException.
> The current BlueprintMetadata.java shall be modified to eliminate the 
> confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to