timothyjward commented on a change in pull request #133:
URL:
https://github.com/apache/aries-jax-rs-whiteboard/pull/133#discussion_r728209177
##########
File path:
jax-rs.whiteboard/src/main/java/org/apache/aries/jax/rs/whiteboard/internal/client/ClientBuilderImpl.java
##########
@@ -19,9 +19,6 @@
import
org.apache.aries.jax.rs.whiteboard.cxf.jaxrs.client.PromiseRxInvokerProviderImpl;
-import aQute.bnd.annotation.spi.ServiceProvider;
-
-@ServiceProvider(javax.ws.rs.client.ClientBuilder.class)
Review comment:
I get the same failure on the master branch without this PR. I don't
think the failure is related to this change.
Without this change there is a catastrophic timing issue. If CXF isn't
started when you try to access the Client (or SSE, or a few other things) then
it tries to initialise the CXF HTTP stack and fails. This failure is cached and
can only be cleared by restarting the framework, or refreshing all the CXF
bundles.
The change doesn't remove service loader (which is necessary to make the
static use work), just the service registration. By doing it manually Aries
JAX-RS whiteboard can delay until the services are safe to use.
##########
File path:
jax-rs.whiteboard/src/main/java/org/apache/aries/jax/rs/whiteboard/internal/client/ClientBuilderImpl.java
##########
@@ -19,9 +19,6 @@
import
org.apache.aries.jax.rs.whiteboard.cxf.jaxrs.client.PromiseRxInvokerProviderImpl;
-import aQute.bnd.annotation.spi.ServiceProvider;
-
-@ServiceProvider(javax.ws.rs.client.ClientBuilder.class)
Review comment:
> because of this removal, given the following test:
> ...
> I get the following exception:
I get the same failure on the master branch without this PR. I don't think
the failure is related to this change.
Without this change there is a catastrophic timing issue. If CXF isn't
started when you try to access the Client (or SSE, or a few other things) then
it tries to initialise the CXF HTTP stack and fails. This failure is cached and
can only be cleared by restarting the framework, or refreshing all the CXF
bundles.
The change doesn't remove service loader (which is necessary to make the
static use work), just the service registration. By doing it manually Aries
JAX-RS whiteboard can delay until the services are safe to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@aries.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
