[GitHub] [aries-jax-rs-whiteboard] wborn commented on pull request #135: Fix JUnit dependency scope

[GitBox]

wborn commented on pull request #135:
URL: 
https://github.com/apache/aries-jax-rs-whiteboard/pull/135#issuecomment-957491848


   Thanks for having a look at this @rotty3000! I've build the 2.0.2-SNAPSHOT 
of your branch and removed the junit/logback-core excludes in our POM and 
indeed these dependencies are now gone. :+1: 
   
   ![Screenshot from 2021-11-02 
13-37-01](https://user-images.githubusercontent.com/12213581/139848609-b92606ac-e6ea-421d-84c7-7e30969f8ac9.png)
   
   I think the only remaining issue are:
   * org.apache.aries.component-dsl.component-dsl:1.2.2 is still having the 
junit dependency so hopefully that can be fixed with an update
   * junit-jupiter-api on your branch still has a [compile instead of a test 
scope](https://github.com/rotty3000/aries-jax-rs-whiteboard/blob/d622397c106b3e9a5f4c58602ebc6b8cbb198935/pom.xml#L355-L359)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@aries.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org