Ah ok. Catcha. I propose to focus on Java 17/18 for new release (the tests probably needs an update). This release just upgrades to ASM 9.2 (opcode 18) for third party. Thoughts ?
Regards JB > Le 2 janv. 2022 à 11:28, Dominik Przybysz <alien11...@gmail.com> a écrit : > > Works fine with java 8 and 11, but not with 17 and 18ea > > I thought that it should work with modern Java, especially when I saw that > you have upgraded ASM to support JDK 18. > > niedz., 2 sty 2022 o 11:20 Jean-Baptiste Onofre <j...@nanthrax.net> > napisał(a): > >> Hi, >> >> I built with Java 8: >> >> java version "1.8.0_301" >> Java(TM) SE Runtime Environment (build 1.8.0_301-b09) >> >> And it works for me. >> >> Do you also have the same issue on trunk ? >> >> Regards >> JB >> >>> Le 2 janv. 2022 à 10:43, Dominik Przybysz <alien11...@gmail.com> a >> écrit : >>> >>> Hi, >>> I tried to run maven on this repository and tests fail on >>> Java 18.ea.29-open with standard verify_staged_release script. >>> Do I need to do sth or sth is missing? >>> >>> [INFO] Results: >>> [INFO] >>> [ERROR] Failures: >>> [ERROR] WovenProxyGeneratorTest.testWovenProxyIsSynthetic:489 >>> [ERROR] >>> >> WovenProxyPlusSubclassGeneratorTest>WovenProxyGeneratorTest.testWovenProxyIsSynthetic:489 >>> [ERROR] Errors: >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [ERROR] >>> >> ProxySubclassGeneratorTest.setUp:78->getGeneratedSubclass:351->getProxyClass:403 >>> » InaccessibleObject >>> [INFO] >>> [ERROR] Tests run: 123, Failures: 2, Errors: 23, Skipped: 0 >>> [INFO] >>> >>> More detailed error example: >>> >>> [ERROR] >>> testGenerics(org.apache.aries.blueprint.proxy.ProxySubclassGeneratorTest) >>> Time elapsed: 0.007 s <<< ERROR! >>> java.lang.reflect.InaccessibleObjectException: Unable to make protected >>> final java.lang.Class >>> >> java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) >>> throws java.lang.ClassFormatError accessible: module java.base does not >>> "opens java.lang" to unnamed module @1f0eba3c >>> at >>> >> org.apache.aries.blueprint.proxy.ProxySubclassGeneratorTest.getProxyClass(ProxySubclassGeneratorTest.java:403) >>> at >>> >> org.apache.aries.blueprint.proxy.ProxySubclassGeneratorTest.getGeneratedSubclass(ProxySubclassGeneratorTest.java:351) >>> at >>> >> org.apache.aries.blueprint.proxy.ProxySubclassGeneratorTest.setUp(ProxySubclassGeneratorTest.java:78) >>> >>> >>> niedz., 2 sty 2022 o 08:01 Jean-Baptiste Onofre <j...@nanthrax.net> >>> napisał(a): >>> >>>> Hi all, >>>> >>>> I submit Aries Proxy Impl 1.1.12 release to your vote. >>>> This release supports JDK18+ by upgrading to ASM 9.2. >>>> >>>> Please, take a look on Release Notes for details. >>>> >>>> Release Notes: >>>> >>>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310981&version=12351182 >>>> >>>> Staging Maven Repository: >>>> https://repository.apache.org/content/repositories/orgapachearies-1205/ >>>> >>>> Staging Dist Repository: >>>> https://dist.apache.org/repos/dist/dev/aries/proxy-impl/1.1.12/ >>>> >>>> Git tag: >>>> org.apache.aries.proxy-1.1.12 >>>> >>>> Please vote to approve this release: >>>> >>>> [ ] +1 Approve the release >>>> [ ] -1 Don't approve the release (please provide specific comments) >>>> >>>> This vote will be open for at least 72 hours. >>>> >>>> Regards >>>> JB >>> >>> >>> >>> -- >>> Pozdrawiam / Regards, >>> Dominik Przybysz >> >> > > -- > Pozdrawiam / Regards, > Dominik Przybysz
