stiemannkj1 commented on PR #215: URL: https://github.com/apache/aries/pull/215#issuecomment-1495042270
> I’m not sure why the Java 8 check is present? Is there a reason not to include JSR inlining at all times? Only performance. I can add a comment to that effect but Java 8+ compiled classes are guaranteed not have JSR/RET instructions. I believe weaving takes place for every class loaded after SPI-Fly is activated, so it could be quite costly to apply these unnecessary checks when the vast majority of classes are Java 8+ these days. I'd like to keep the check along with a comment as I don't think it adds significant complexity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
