sabberworm commented on code in PR #294:
URL: https://github.com/apache/aries/pull/294#discussion_r1622016485
##########
spi-fly/spi-fly-static-bundle/pom.xml:
##########
@@ -78,6 +78,24 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>properties-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>initialize</phase>
+ <goals>
+ <goal>read-project-properties</goal>
+ </goals>
+ <configuration>
+ <files>
+
<file>../spi-fly-core/src/main/resources/org/apache/aries/spifly/packageinfo</file>
Review Comment:
I tried using the `${parent.basedir}` placeholder here to make the lookup
dynamic but it seems placeholders are not supported here.
##########
spi-fly/spi-fly-static-bundle/pom.xml:
##########
@@ -78,6 +78,24 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>properties-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>initialize</phase>
+ <goals>
+ <goal>read-project-properties</goal>
+ </goals>
+ <configuration>
+ <files>
+
<file>../spi-fly-core/src/main/resources/org/apache/aries/spifly/packageinfo</file>
Review Comment:
I tried using the `${parent.basedir}` placeholder to make the lookup dynamic
but it seems placeholders are not supported here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
