amichair commented on code in PR #93: URL: https://github.com/apache/aries-rsa/pull/93#discussion_r3145313868
########## discovery/tcp/src/main/java/org/apache/aries/rsa/discovery/tcp/InterestManager.java: ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.aries.rsa.discovery.tcp; + +import org.osgi.framework.ServiceReference; +import org.osgi.service.remoteserviceadmin.EndpointDescription; +import org.osgi.service.remoteserviceadmin.EndpointEvent; +import org.osgi.service.remoteserviceadmin.EndpointEventListener; + +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; + +import static org.osgi.service.remoteserviceadmin.EndpointEvent.*; + +/** + * Manages all known local EndpointEventListeners along with their interests (scopes), + * as well as all known remote endpoints, and notifies the former about the latter. + */ +public class InterestManager { + // listener to its interest Review Comment: I'm ambivalent on this one. Many consider javadocs the way to document a public api or non-intuitive internal methods, but I've rarely seen javadocs used to document private fields... these are more like comments inside a method (which you wouldn't place in a javadoc) - some private implementation detail that you want to explain to make the code more easily readable to the maintainer but is not really processed or used or a defined as part of a proper contract... In questions of style etc. I would normally defer to the project standards, but unfortunately the project standard here is mainly to not document anything ;-) (although I've done my best over the years to change that, mainly by adding class javadocs explaining the components and relationships and such). but if you feel strongly about it or it is considered part of the coding style standard of course I'll change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
