amichair commented on code in PR #129:
URL: https://github.com/apache/aries-rsa/pull/129#discussion_r3330503330


##########
itests/tck/tck-tcp-tcp.bndrun:
##########
@@ -80,35 +92,59 @@
     javax.xml.stream.util; version=1.0
 -runfw: org.eclipse.osgi;version='[3.24.100,3.24.101)'
 -runee: JavaSE-${java.specification.version}
--runrequires:\
-    
osgi.identity;filter:='(osgi.identity=org.osgi.test.cases.remoteserviceadmin)',\
-    
osgi.identity;filter:='(osgi.identity=org.apache.aries.rsa.topology-manager)',\
-    
osgi.identity;filter:='(osgi.identity=org.ops4j.pax.logging.pax-logging-log4j2)'
 -runblacklist:\
     osgi.identity;filter:='(osgi.identity=osgi.cmpn)'
--runbundles:\
-    org.ops4j.pax.logging.pax-logging-api;version='[2.3.3,2.3.4)',\
-    org.ops4j.pax.logging.pax-logging-log4j2;version='[2.3.3,2.3.4)',\
-    org.osgi.service.component;version='[1.5.1,1.5.2)',\
-    org.osgi.util.function;version='[1.2.0,1.2.1)',\
-    org.osgi.util.promise;version='[1.3.0,1.3.1)',\
-    org.apache.felix.scr;version='[2.2.18,2.2.19)',\
-    org.apache.felix.fileinstall;version='[3.7.4,3.7.5)',\
-    org.apache.felix.configadmin;version='[1.9.26,1.9.27)',\
-    org.apache.felix.eventadmin;version='[1.6.4,1.6.5)',\
-    org.glassfish.hk2.osgi-resource-locator;version='[3.0.0,3.0.1)',\
-    org.apache.servicemix.bundles.junit;version='[4.13.2,4.13.3)',\
-    assertj-core;version='[3.27.7,3.27.8)',\
-    net.bytebuddy.byte-buddy;version='[1.18.8,1.18.9)',\
-    jakarta.activation-api;version='[2.1.4,2.1.5)',\
-    jakarta.xml.bind-api;version='[4.0.5,4.0.6)',\
-    com.sun.xml.bind.jaxb-core;version='[4.0.8,4.0.9)',\
-    com.sun.xml.bind.jaxb-impl;version='[4.0.8,4.0.9)',\
-    com.sun.istack.commons-runtime;version='[4.2.0,4.2.1)',\
-    org.apache.aries.rsa.spi;version='[2.0.0,2.0.1)',\
-    org.apache.aries.rsa.discovery.local;version='[2.0.0,2.0.1)',\
-    org.apache.aries.rsa.discovery.tcp;version='[2.0.0,2.0.1)',\
-    org.apache.aries.rsa.provider.tcp;version='[2.0.0,2.0.1)',\
-    org.apache.aries.rsa.core;version='[2.0.0,2.0.1)',\
-    org.apache.aries.rsa.topology-manager;version='[2.0.0,2.0.1)',\
-    org.osgi.test.cases.remoteserviceadmin;version='[8.1.0,8.1.1)'
+
+-runrequires:\
+    
osgi.identity;filter:='(osgi.identity=org.ops4j.pax.logging.pax-logging-api)',\
+    
osgi.identity;filter:='(osgi.identity=org.ops4j.pax.logging.pax-logging-log4j2)',\
+    osgi.identity;filter:='(osgi.identity=org.osgi.service.component)',\
+    osgi.identity;filter:='(osgi.identity=org.osgi.util.function)',\
+    osgi.identity;filter:='(osgi.identity=org.osgi.util.promise)',\
+    osgi.identity;filter:='(osgi.identity=org.apache.felix.scr)',\
+    osgi.identity;filter:='(osgi.identity=org.apache.felix.fileinstall)',\
+    osgi.identity;filter:='(osgi.identity=org.apache.felix.configadmin)',\
+    osgi.identity;filter:='(osgi.identity=org.apache.felix.eventadmin)',\
+    
osgi.identity;filter:='(osgi.identity=org.glassfish.hk2.osgi-resource-locator)',\
+    
osgi.identity;filter:='(osgi.identity=org.apache.servicemix.bundles.junit)',\
+    osgi.identity;filter:='(osgi.identity=assertj-core)',\
+    osgi.identity;filter:='(osgi.identity=net.bytebuddy.byte-buddy)',\
+    osgi.identity;filter:='(osgi.identity=jakarta.activation-api)',\
+    osgi.identity;filter:='(osgi.identity=jakarta.xml.bind-api)',\
+    osgi.identity;filter:='(osgi.identity=com.sun.xml.bind.jaxb-core)',\
+    osgi.identity;filter:='(osgi.identity=com.sun.xml.bind.jaxb-impl)',\
+    osgi.identity;filter:='(osgi.identity=com.sun.istack.commons-runtime)',\
+    osgi.identity;filter:='(osgi.identity=org.apache.aries.rsa.spi)',\
+    
osgi.identity;filter:='(osgi.identity=org.apache.aries.rsa.discovery.local)',\
+    
osgi.identity;filter:='(osgi.identity=org.apache.aries.rsa.discovery.tcp)',\
+    osgi.identity;filter:='(osgi.identity=org.apache.aries.rsa.provider.tcp)',\
+    osgi.identity;filter:='(osgi.identity=org.apache.aries.rsa.core)',\
+    
osgi.identity;filter:='(osgi.identity=org.apache.aries.rsa.topology-manager)',\
+    
osgi.identity;filter:='(osgi.identity=org.osgi.test.cases.remoteserviceadmin)'
+
+-runbundles: \
+       assertj-core;version='[3.27.7,3.27.8)',\

Review Comment:
   if it works as expected, the runbundles property is rewritten by the bnd 
maven plugin with the versions from the pom - there shouldn't be any need to 
change versions manually.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to