stbischof opened a new pull request, #164: URL: https://github.com/apache/aries-cdi/pull/164
OSGi CDI (Compendium 152, Container Component) defines the default container id as `osgi.cdi.` + Bundle-SymbolicName, and the container component is configured with the container id as its PID. Aries CDI used the bare Bundle-SymbolicName as the default container id. The container PID was `osgi.cdi.` + BSN with `-` replaced by `.`. As a result, `<container id>.enabled` as defined by the spec does not disable the container component. The OSGi CDI TCK (`DisableComponentTests`) fails against Aries CDI 1.1.4 and 1.1.5 because of this. Changes: - `ContainerState`: the default container id is `osgi.cdi.` + BSN, and the container PID is the container id, with no `-` replacement. - `CDIBundlePhaseTest` and the `DisableComponentTests` itest are adjusted. Behaviour change: configurations that used the old PID form (`-` replaced by `.`) or the bare BSN as the container id must use the spec names. Verified: unit tests 222/0, cdi-itests OWB 55/0 and Weld 55/0, and the OSGi CDI TCK against 1.1.6-SNAPSHOT 44/44 plus secure 13/13. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
