Hi all, currently, running json-integration-test with valgrind leads to the following warning: "Syscall param write(buf) points to uninitialised byte(s)". This is caused by PrimitiveBufferBuilder not initializing its data memory. Note: we initialize null_bitmap_data_ by zeroing, i.e. setting all values to not-null by default.
Since having tests pass valgrind might be desirable for the CI, I think we should fix this warning. There are a couple of possibilities: 1. Add suppression. The specs doesn't require padding to have a specific value, so we might consider it to be false positive 2. Add initialization of the padding bytes to ArrayBuilder::FinishIntenal implementations. 3. Generally zero-initialize memory in PoolBuffer. Might be too expensive. Or course there could be number of other options, includeing "do nothing". If we settle on a best option, I can make a PR. Cheers, Dimitri.
