+1 (binding) with a trivial fix.

The following checksum files use absolute paths:

  
https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.12.0-rc2/apache-arrow-0.12.0.tar.gz.sha256
  
https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.12.0-rc2/apache-arrow-0.12.0.tar.gz.sha512

I think that we need to replace the files with basename only
path.

I verified checksums with the following change:

----
diff --git a/dev/release/verify-release-candidate.sh 
b/dev/release/verify-release-candidate.sh
index c8b9c54c..d992c43c 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -83,8 +83,8 @@ fetch_archive() {
   download_rc_file ${dist_name}.tar.gz.sha256
   download_rc_file ${dist_name}.tar.gz.sha512
   gpg --verify ${dist_name}.tar.gz.asc ${dist_name}.tar.gz
-  shasum -a 256 -c ${dist_name}.tar.gz.sha256
-  shasum -a 512 -c ${dist_name}.tar.gz.sha512
+  sed -E -e 's,/+.+/,,g' ${dist_name}.tar.gz.sha256 | shasum -a 256 -c
+  sed -E -e 's,/+.+/,,g' ${dist_name}.tar.gz.sha512 | shasum -a 512 -c
 }
 
 verify_binary_artifacts() {
----

We need to update verify script for changes between 0.11.1
and 0.12.0:

  https://github.com/apache/arrow/pull/3389

I ran the followings on Debian GNU/Linux sid:

  * ARROW_HAVE_CUDA=no CC=gcc-7 CXX=g++-7 
dev/release/verify-release-candidate.sh binaries 0.12.0 2
  * ARROW_HAVE_CUDA=yes CC=gcc-7 CXX=g++-7 
dev/release/verify-release-candidate.sh binaries 0.12.0 2

with:

  * gcc-7 (Debian 7.4.0-2) 7.4.0
  * openjdk version "1.8.0_191"
  * ruby 2.7.0dev (2019-01-05 trunk 66719) [x86_64-linux]
  * Node.js v10.15.0


There is a problem in Plasma + Python + CUDA:

  https://issues.apache.org/jira/browse/ARROW-4246

I don't think that this is a blocker.

Other modules work well with ARROW_HAVE_GPU=yes.


There is a problem with GCC 8:

  https://issues.apache.org/jira/browse/ARROW-4242

I don't think that this is a blocker.


Thanks,
--
kou

In <CAHM19a46QCV=3_b9w9dwttkeb0vesmtnw_xqdtpcoztzxmw...@mail.gmail.com>
  "[VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW" on Sat, 12 Jan 2019 20:56:28 
+0100,
  Krisztián Szűcs <szucs.kriszt...@gmail.com> wrote:

> Hi,
> 
> I'd like to propose the 1st release candidate (RC2) of Apache Arrow version
> 0.12.0. This is a major release consisting of 600 resolved JIRAs [1].
> The previous RCs were not voted, because:
> - RC0: the source archive didn't include required files to build
> gandiva-glib
>   documents, also causing failed binary build for Debian Stretch [6].
> - RC1: compatibility issues with the just released pandas version 0.24.rc1
> [8]
> 
> This release candidate is based on commit:
> 0bbaef451ae9d59799e693df9b2383808516a326 [2]
> 
> The source release rc2 is hosted at [3].
> The binary artifacts are hosted at [4].
> The changelog is located at [5].
> 
> Please download, verify checksums and signatures, run the unit tests,
> and vote on the release. See [7] for how to validate a release candidate.
> 
> The vote will be open for at least 72 hours.
> 
> [ ] +1 Release this as Apache Arrow 0.12.0
> [ ] +0
> [ ] -1 Do not release this as Apache Arrow 0.12.0 because...
> 
> Special thanks to @kou for helping with the uprising issues!
> 
> - Krisztian
> 
> [1]:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20fixVersion%20%3D%200.12.0
> [2]:
> https://github.com/apache/arrow/commit/0bbaef451ae9d59799e693df9b2383808516a326
> <https://github.com/apache/arrow/tree/5ac58233936fcd2213c23adce72a79911c3f1359>
> [3]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.12.0-rc2/
> [4]: https://bintray.com/beta/#/apache/arrow?tab=packages
> [5]:
> https://github.com/apache/arrow/blob/0bbaef451ae9d59799e693df9b2383808516a326/CHANGELOG.md
> [6]: https://travis-ci.org/kszucs/crossbow/builds/478393330
> [7]:
> https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates
> [8]: https://travis-ci.org/kszucs/crossbow/builds/478558640

Reply via email to