Seems fine to me. We never decided against building it but never had a need for it (or perhaps there are some tests we might have written that could have made use of mocks)
On Mon, Jan 14, 2019 at 10:42 PM Micah Kornfield <emkornfi...@gmail.com> wrote: > > Would people be OK if I submitted a PR for this? It is already packaged > with googletest, so I don't think it would require downloading additional > dependencies. > > Pros: > - Don't need to create our own mocks (not terribly hard but a little > boring). It would be useful to have mock Kernel implementations. > - Provides a larger set of matchers that are usable in gtest assertions > > Cons: > - Some additional build time? > - It looks like there is some additional path setups that need to happen > for certain tools (e.g. iwyu) > > Any other gotchas? > > Thanks, > Micah