+1 The Rust implementation is working correctly.
One thing I did just realize though is that the test files that the Rust tests rely on are not packaged up as part of the release. The tests work because I have the PARQUET_TEST_DATA env var pointing to my cloned github repo, but if I just had this release tarball I would not be able to run the tests successfully. I'm assuming this is expected behavior? On Wed, Jan 16, 2019 at 4:59 AM Krisztián Szűcs <szucs.kriszt...@gmail.com> wrote: > Hi, > > I'd like to propose the 2nd voteable release candidate (RC4) of Apache > Arrow > version 0.12.0. This is a major release consisting of 610 resolved JIRAs > [1]. > > We've hit several roadblocks during the release. The most recent issues > were caused by the simultaneous releases of numpy, pandas, and even the > great conda-forge compiler migration, which was finished yesterday [10]: > - RC0: the source archive didn't include required files to build > gandiva-glib > documents, also causing failed binary build for Debian Stretch [6]. > - RC1: compatibility issues with the just released pandas version 0.24.rc1 > [8] > - RC2: voted, but decided to cut a new one because of faulty safe casts > [11] > - RC3: various conda-forge problems and compatibility with pandas 0.22 [9] > > This release candidate is based on commit: > 8ca41384b5324bfd0ef3d3ed3f728e1d10ed73f0 [2] > > The source release rc4 is hosted at [3]. > The binary artifacts are hosted at [4]. > The changelog is located at [5]. > > Please download, verify checksums and signatures, run the unit tests, > and vote on the release. See [7] for how to validate a release candidate. > Please use the verification script from the master, because it has required > a patch to work after the recent conda-forge compiler migration [12]. > > The vote will be open for at least 72 hours. > > [ ] +1 Release this as Apache Arrow 0.12.0 > [ ] +0 > [ ] -1 Do not release this as Apache Arrow 0.12.0 because... > > - Krisztian > > [1]: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20fixVersion%20%3D%200.12.0 > [2]: > > https://github.com/apache/arrow/commit/8ca41384b5324bfd0ef3d3ed3f728e1d10ed73f0 > < > https://github.com/apache/arrow/tree/5ac58233936fcd2213c23adce72a79911c3f1359 > > > [3]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.12.0-rc4/ > <https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.12.0-rc2/> > [4]: https://bintray.com/apache/arrow > <https://bintray.com/beta/#/apache/arrow?tab=packages> > [5]: > > https://github.com/apache/arrow/blob/8ca41384b5324bfd0ef3d3ed3f728e1d10ed73f0/CHANGELOG.md > < > https://github.com/apache/arrow/blob/0bbaef451ae9d59799e693df9b2383808516a326/CHANGELOG.md > > > [6]: https://travis-ci.org/kszucs/crossbow/builds/478393330 > [7]: > > https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates > [8]: https://travis-ci.org/kszucs/crossbow/builds/4785586402 > <https://travis-ci.org/kszucs/crossbow/builds/478558640> > [9]: https://github.com/apache/arrow/pull/3410 > [10] https://conda-forge.org/status/ > [11]: > https://mail-archives.apache.org/mod_mbox/arrow-dev/201901.mbox/browser > [12]: https://github.com/apache/arrow/pull/3413 >
