hi Andy -- yes you can definitely back out the patch if it becomes an issue.
As soon as the CLAs are sorted I can run the IP clearance vote on general@incubator. Thanks for your patience on this On Mon, Jan 28, 2019 at 7:58 PM Andy Grove <andygrov...@gmail.com> wrote: > > I'm making good progress with the audit and so far I have found ~50 lines > of code from one contributor that is currently part of the proposed > donation. > > I have reached out via github issues to see if I can make contact. > > This code could also be removed from the donation with no consequence. I'm > assuming that is an acceptable option if I can't make contact or get an > ICLA signed? > > Andy. > > On Mon, Jan 28, 2019 at 7:48 AM Wes McKinney <wesmck...@gmail.com> wrote: > > > On Mon, Jan 28, 2019 at 8:42 AM Andy Grove <andygrov...@gmail.com> wrote: > > > > > > Thanks. I'm excited to be able to donate this code. > > > > > > I've just completed a quick first pass audit of the contributions and I > > > don't think any of them apply to the code being donated but I will do a > > > thorough audit to confirm over the next couple of days. The commits > > > generally fall into these categories: > > > > > > - Contributions to the original POC (I rewrote DataFusion pretty much > > from > > > scratch a couple months ago, leveraging work that has happened in Arrow > > > since the POC) > > > - Contributions to the SQL parser, which got split out into a separate > > > crate and is not being donated > > > - Contributions to the SQL console (which is not being donated and I plan > > > to re-implement from scratch someday) > > > > > > I just need to make sure none of the contributions carried over into the > > > rewrite, which is why it will take me a little time. > > > > > > I do have one clarification question though. Do we require ICLA for > > things > > > like these: > > > > > > - Adding lines to .gitignore files > > > - Fixing spelling mistakes in README? > > > > No, these aren't needed > > > > > > > > Thanks, > > > > > > Andy. > > > > > > > > > > > > > > > On Sun, Jan 27, 2019 at 11:24 PM Wes McKinney <wesmck...@gmail.com> > > wrote: > > > > > > > The vote carries with 5 binding +1 votes and 6 non-binding +1 > > > > > > > > Andy -- from the look of > > > > > > > > https://github.com/andygrove/datafusion/graphs/contributors > > > > > > > > you may have to track down some contributors to send ICLAs to the > > > > Apache secretary to be able to move forward. Some of the IP from these > > > > individuals may not be the actual code that's being donated, can you > > > > let me know? Some of the contributors should already be in the ICLA > > > > list from prior donations or being committers on other Apache > > > > projects. > > > > > > > > - Wes > > > > > > > > On Sun, Jan 27, 2019 at 11:59 PM Andy Grove <andygrov...@gmail.com> > > wrote: > > > > > > > > > > Thanks for all the votes on this donation! > > > > > > > > > > Wes - it looks like votes have stopped now. Are the current number of > > > > votes > > > > > sufficient? > > > > > > > > > > Thanks, > > > > > > > > > > Andy. > > > > > > > > > > > > > > > On Thu, Jan 24, 2019 at 8:43 PM Kouhei Sutou <k...@clear-code.com> > > wrote: > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > In < > > cajpuwmbqinqyurpzou2yzcvhid_vsfyoo_rqvcbx5pgqqb+...@mail.gmail.com > > > > > > > > > > > "[VOTE] Accept donation of Rust DataFusion library for Apache > > Arrow" > > > > on > > > > > > Tue, 22 Jan 2019 19:05:16 -0600, > > > > > > Wes McKinney <wesmck...@gmail.com> wrote: > > > > > > > > > > > > > Dear all, > > > > > > > > > > > > > > The developers of DataFusion, an analytical query engine written > > > > > > > in Rust, based on the Arrow columnar memory format, are proposing > > > > > > > to donate the code to Apache Arrow: > > > > > > > > > > > > > > https://github.com/andygrove/datafusion > > > > > > > > > > > > > > The community has had an opportunity to discuss this [1] and > > > > > > > there do not seem to be objections to this. Andy Grove has staged > > > > > > > the code donation in the form of a pull request: > > > > > > > > > > > > > > https://github.com/apache/arrow/pull/3399 > > > > > > > > > > > > > > This vote is to determine if the Arrow PMC is in favor of > > accepting > > > > > > > this donation. If the vote passes, the PMC and the authors of the > > > > code > > > > > > > will work together to complete the ASF IP Clearance process > > > > > > > (http://incubator.apache.org/ip-clearance/) and import this Rust > > > > > > > codebase implementation into Apache Arrow. > > > > > > > > > > > > > > [ ] +1 : Accept contribution of DataFusion Rust library > > > > > > > [ ] 0 : No opinion > > > > > > > [ ] -1 : Reject contribution because... > > > > > > > > > > > > > > Here is my vote: +1 > > > > > > > > > > > > > > The vote will be open for at least 72 hours. > > > > > > > > > > > > > > Thanks, > > > > > > > Wes > > > > > > > > > > > > > > [1]: > > > > > > > > > > > > https://lists.apache.org/thread.html/2f6c14e9f5a9ab41b0b591b2242741b23e5528fb28e79ac0e2c9349a@%3Cdev.arrow.apache.org%3E > > > > > > > > > > > >
