Hi all,

I’d like to discuss the versioning of the parquet shared libs that are built 
when you use -DARROW_PARQUET=ON.  My observation is that back when parquet-cpp 
was a separate project the shared libs were versioned using the parquet-cpp 
version number (e.g 1.4.0).  Since moving to a single repo, the parquet shared 
libraries are now versioned with the arrow version number (e.g. 0.12.0)

I assumed this wasn't carried over to the mono-repo and opened a JIRA [1] and a 
PR [2] to version the parquet shared libraries separately from Arrow.  I've 
read through the thread discussing the mono-repo [3] and otherwise can't find 
mention of Wes' comment that:

"I had thought we had discussed using the same SO version for all shared 
libraries produced by a particular build. Let's discuss this some more."

I see some value in maintaining the parquet library version but equally see 
value in matching the arrow version.  I'm not sure this is correct, but I still 
consider parquet-cpp somewhat separate 

(it has its own JIRA).  An additional proposal is that we could modify the 
CREATED_BY_VERSION [4] to reference the Arrow version number for additional 
traceability with Parquet files written using the mono-repo.

Any additional thoughts or a link to prior discussion on shared lib versioning 
would be much appreciated.

Thanks!

Hatem

[1] https://issues.apache.org/jira/browse/PARQUET-1540
[2] https://github.com/apache/arrow/pull/3743
[3] 
https://lists.apache.org/thread.html/efdb7de9fd5f3e7d345caa85639ca65fa2c41f50a977b3eca959e9f9@%3Cdev.arrow.apache.org%3E
[4] 
https://github.com/apache/arrow/blob/master/cpp/src/parquet/parquet_version.h.in





Reply via email to