Yes I do not think vendoring curl is a good idea
On Wed, Feb 27, 2019 at 10:30 AM Antoine Pitrou <solip...@pitrou.net> wrote: > > > Vendoring curl sounds a bit crazy IMHO. We'll end up having to vendor a > TLS library and who knows what else... > > Regards > > Antoine. > > > On Wed, 27 Feb 2019 11:16:49 -0500 > Francois Saint-Jacques <fsaintjacq...@gmail.com> wrote: > > There's a good chance we end up using curl for the dataset project. Curl > > has a new url API https://github.com/curl/curl/wiki/URL-API , but it > > requires a recent version (7.62.0 october 2018) which means vendoring. > > > > François > > > > On Wed, Feb 27, 2019 at 11:06 AM Antoine Pitrou <solip...@pitrou.net> wrote: > > > > > > > > Hello, > > > > > > As part of ARROW-4651, we would need to have a URI parsing library in > > > the C++ project. > > > > > > One such library is https://github.com/cpp-netlib/uri, it's based on a > > > previous proposal for the standard C++ library. It has no dependencies > > > except boost::algorithm. > > > > > > One problem is that the library ships its own backports of > > > `std::string_view` and `std::optional`. We already have a backport of > > > `std::string_view` in our source tree (it seems more complete). So we > > > would need to patch the uri library to use our backport. Maintaining > > > the patch will be a bit annoying. > > > > > > Another possibility is to use the C-only, no-dependencies uriparser > > > library (and write a small C++ wrapper around it): > > > https://uriparser.github.io/ > > > > > > Regards > > > > > > Antoine. > > > > > > > > > > > > > >
