Uwe L. Korn created ARROW-4760:
----------------------------------
Summary: [C++] protobuf 3.7 defines EXPECT_OK that clashes with
Arrow's macro
Key: ARROW-4760
URL: https://issues.apache.org/jira/browse/ARROW-4760
Project: Apache Arrow
Issue Type: Bug
Components: C++
Reporter: Uwe L. Korn
Assignee: Uwe L. Korn
Fix For: 0.13.0
This fails for me with the following error:
{code:java}
/home/travis/build/xhochy/arrow/cpp/src/arrow/flight/test-util.cc
In file included from
/home/travis/build/xhochy/arrow/cpp-toolchain/include/google/protobuf/util/type_resolver.h:39:0,
from
/home/travis/build/xhochy/arrow/cpp-toolchain/include/google/protobuf/util/json_util.h:37,
from
/home/travis/build/xhochy/arrow/cpp-toolchain/include/grpcpp/impl/codegen/config_protobuf.h:70,
from
/home/travis/build/xhochy/arrow/cpp/src/arrow/flight/customize_protobuf.h:23,
from
/home/travis/build/xhochy/arrow/cpp/src/arrow/flight/protocol-internal.h:20,
from
/home/travis/build/xhochy/arrow/cpp/src/arrow/flight/internal.h:23,
from
/home/travis/build/xhochy/arrow/cpp/src/arrow/flight/test-util.cc:35:
/home/travis/build/xhochy/arrow/cpp-toolchain/include/google/protobuf/stubs/status.h:111:0:
error: "EXPECT_OK" redefined [-Werror]
#define EXPECT_OK(value) EXPECT_TRUE((value).ok())
In file included from
/home/travis/build/xhochy/arrow/cpp/src/arrow/ipc/test-common.h:35:0,
from
/home/travis/build/xhochy/arrow/cpp/src/arrow/flight/test-util.cc:30:
/home/travis/build/xhochy/arrow/cpp/src/arrow/testing/gtest_util.h:80:0: note:
this is the location of the previous definition
#define EXPECT_OK(expr) \
cc1plus: all warnings being treated as errors{code}
I would workaround this by renaming our {{EXPECT_OK}} to {{ARROW_EXPECT_OK}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
