I just merged https://github.com/apache/arrow/pull/4006 that bumps the node requirement to 11.12 to avoid this issue. Krisztian, can you cut an RC1 with that change included?
Brian On Thu, Mar 21, 2019 at 10:06 AM Brian Hulette <hulet...@gmail.com> wrote: > It looks like this was an issue with node v11.11 that was resolved in > v11.12 [1,2]. Can you try upgrading and running again? > > [1] > https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V11.md#2019-03-15-version-11120-current-bridgear > [2] https://github.com/nodejs/node/pull/26488 > > On Thu, Mar 21, 2019 at 8:00 AM Uwe L. Korn <uw...@xhochy.com> wrote: > >> This saldy fails locally for me on OSX High Sierra: >> >> ``` >> + npm run test >> >> > apache-arrow@0.4.1 test >> /private/var/folders/3j/b8ctc4654q71hd_nqqh8yxc00000gp/T/arrow-js-0.4.1.XXXXX.8XkDsa8C/apache-arrow-js-0.4.1 >> > NODE_NO_WARNINGS=1 gulp test >> >> [15:23:02] Using gulpfile >> /private/var/folders/3j/b8ctc4654q71hd_nqqh8yxc00000gp/T/arrow-js-0.4.1.XXXXX.8XkDsa8C/apache-arrow-js-0.4.1/gulpfile.js >> [15:23:02] Starting 'test'... >> [15:23:02] Starting 'test:ts'... >> [15:23:02] Starting 'test:src'... >> [15:23:02] Starting 'test:apache-arrow'... >> >> ● Test suite failed to run >> >> TypeError: Cannot assign to read only property >> 'Symbol(Symbol.toStringTag)' of object '#<process>' >> >> at exports.default >> (node_modules/jest-util/build/create_process_object.js:15:34) >> ``` >> >> This is the same error as in the nightlies but the fix there doesn't help >> for me locally. >> >> Uwe >> >> On Thu, Mar 21, 2019, at 2:41 AM, Brian Hulette wrote: >> > +1 (non-binding) >> > >> > Ran js-verify-release-candidate.sh on Archlinux w/ node v11.12.0 >> > >> > Thanks Krisztian! >> > Brian >> > >> > On Wed, Mar 20, 2019 at 5:40 PM Paul Taylor <ptay...@apache.org> wrote: >> > >> > > +1 non-binding >> > > >> > > Ran `dev/release/js-verify-release-candidate.sh 0.4.1 0` on MacOS High >> > > Sierra w/ node v11.6.0 >> > > >> > > >> > > On Wed, Mar 20, 2019 at 5:21 PM Kouhei Sutou <k...@clear-code.com> >> wrote: >> > > >> > > > +1 (binding) >> > > > >> > > > I ran the followings on Debian GNU/Linux sid: >> > > > >> > > > * dev/release/js-verify-release-candidate.sh 0.4.1 0 >> > > > >> > > > with: >> > > > >> > > > * Node.js v11.12.0 >> > > > >> > > > Thanks, >> > > > -- >> > > > kou >> > > > >> > > > In <CAHM19a7WT+pa4MTHd=rveD=RjgTCrv6gDGKcyKaR87z1Y= >> z...@mail.gmail.com> >> > > > "[VOTE] Release Apache Arrow JS 0.4.1 - RC0" on Thu, 21 Mar 2019 >> > > > 00:09:54 +0100, >> > > > Krisztián Szűcs <szucs.kriszt...@gmail.com> wrote: >> > > > >> > > > > Hello all, >> > > > > >> > > > > I would like to propose the following release candidate (rc0) of >> Apache >> > > > > Arrow JavaScript version 0.4.1. >> > > > > >> > > > > The source release rc0 is hosted at [1]. >> > > > > >> > > > > This release candidate is based on commit >> > > > > f55542eeb59dde8ff4512c707b9eca1b43b62073 >> > > > > >> > > > > Please download, verify checksums and signatures, run the unit >> tests, >> > > and >> > > > > vote >> > > > > on the release. The easiest way is to use the JavaScript-specific >> > > release >> > > > > verification script dev/release/js-verify-release-candidate.sh. >> > > > > >> > > > > [ ] +1 Release this as Apache Arrow JavaScript 0.4.1 >> > > > > [ ] +0 >> > > > > [ ] -1 Do not release this as Apache Arrow JavaScript 0.4.1 >> because... >> > > > > >> > > > > >> > > > > How to validate a release signature: >> > > > > https://httpd.apache.org/dev/verification.html >> > > > > >> > > > > [1]: >> > > > >> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-js-0.4.1-rc0/ >> > > > > [2]: >> > > > > >> > > > >> > > >> https://github.com/apache/arrow/tree/f55542eeb59dde8ff4512c707b9eca1b43b62073 >> > > > >> > > >> > >> >
