+1 (binding) I also ran the source and binary verification on Ubuntu 18.04 -- I was able to run all the tests in the source verification and all looks good. If it weren't a patch release I'd also run Windows, but since we have Python packages for Windows that gives me confidence =)
Note that the binary verification for CentOS 6 and 7 flaked on me with an error similar to https://bugzilla.redhat.com/show_bug.cgi?id=1528634 I re-ran just those builds and it passed, so I guess it was a transient issue. On Wed, Jul 17, 2019 at 8:35 PM Wes McKinney <wesmck...@gmail.com> wrote: > > For the record, if Google had taken it upon themselves to work with > the PyPA / the Python community generally to fix the wheel standard to > suit TensorFlow instead of flagrantly violating it, it would likely > also have addressed the core problems that are causing me to give up > on wheel development. > > On Wed, Jul 17, 2019 at 8:31 PM Wes McKinney <wesmck...@gmail.com> wrote: > > > > Krisz is the RM so he can decide but: > > > > We've taken the position that we won't be inconvenienced by issues > > stemming from TensorFlow's non-compliant wheels. Producing a new > > release candidate is several hours of work, at least, so if it were me > > this alone would not be reason enough to cancel an RC. > > > > On Wed, Jul 17, 2019 at 7:23 PM Zhuo Peng <z...@sealscript.net> wrote: > > > > > > Hi Krisztián, > > > > > > Sorry if it's too late, but is it possible to also include > > > https://github.com/apache/arrow/pull/4883 in the release? This would help > > > resolve https://github.com/apache/arrow/issues/4472 . > > > > > > Thanks, > > > > > > Zhuo > > > > > > On Wed, Jul 17, 2019 at 3:00 AM Antoine Pitrou <anto...@python.org> wrote: > > > > > > > > > > > +1 (binding). > > > > > > > > Tested on Ubuntu 18.04.2 (x86-64) with CUDA enabled: > > > > > > > > - binaries verification worked fine > > > > - source verification worked until the npm step, which failed (I don't > > > > have npm installed) > > > > > > > > Regards > > > > > > > > Antoine. > > > > > > > > > > > > Le 17/07/2019 à 04:54, Krisztián Szűcs a écrit : > > > > > Hi, > > > > > > > > > > I would like to propose the following release candidate (RC0) of > > > > > Apache > > > > > Arrow version 0.14.1. This is a patch release consiting of 47 resolved > > > > > JIRA issues[1]. > > > > > > > > > > This release candidate is based on commit: > > > > > 5f564424c71cef12619522cdde59be5f69b31b68 [2] > > > > > > > > > > The source release rc0 is hosted at [3]. > > > > > The binary artifacts are hosted at [4][5][6][7]. > > > > > The changelog is located at [8]. > > > > > > > > > > Please download, verify checksums and signatures, run the unit tests, > > > > > and vote on the release. See [9] for how to validate a release > > > > > candidate. > > > > > > > > > > The vote will be open for at least 72 hours. > > > > > > > > > > [ ] +1 Release this as Apache Arrow 0.14.1 > > > > > [ ] +0 > > > > > [ ] -1 Do not release this as Apache Arrow 0.14.1 because... > > > > > > > > > > [1]: > > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%200.14.1 > > > > > [2]: > > > > > > > > > https://github.com/apache/arrow/tree/5f564424c71cef12619522cdde59be5f69b31b68 > > > > > [3]: > > > > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.14.1-rc0 > > > > > [4]: https://bintray.com/apache/arrow/centos-rc/0.14.1-rc0 > > > > > [5]: https://bintray.com/apache/arrow/debian-rc/0.14.1-rc0 > > > > > [6]: https://bintray.com/apache/arrow/python-rc/0.14.1-rc0 > > > > > [7]: https://bintray.com/apache/arrow/ubuntu-rc/0.14.1-rc0 > > > > > [8]: > > > > > > > > > https://github.com/apache/arrow/blob/5f564424c71cef12619522cdde59be5f69b31b68/CHANGELOG.md > > > > > [9]: > > > > > > > > > https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates > > > > > > > > >
