Le 04/10/2019 à 19:01, Zhuo Peng a écrit : > > backports are cool for internal use, but probably not so if a public API > accepts it? (because you vendor the headers in (i.e. namespace, symbol names > unchanged), they might clash with headers that a client uses).
This is true unfortunately. >>> And btw, was -std=gnu++11 an intentional choice? what gnu extensions does >>> the library rely on? >> >> None, AFAIK. Arrow compiles on MSVC fine. Where is -std=gnu++11 added? > https://github.com/apache/arrow/blob/3129e3ed90219ecfffe2a25ce5820eec8cc947d0/cpp/cmake_modules/SetupCxxFlags.cmake#L33 > > https://cmake.org/cmake/help/v3.1/prop_tgt/CXX_STANDARD.html Right, so this is a CMake decision. I think we require only plain C++11 (but we may enable additional features on some compilers, provided there's a fallback). Regards Antoine.